Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: appengine/findit/waterfall/send_notification_for_culprit_pipeline.py

Issue 2488113005: [Findit] Re-org code. (Closed)
Patch Set: Rebase. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from datetime import datetime 5 from datetime import datetime
6 import logging 6 import logging
7 import textwrap 7 import textwrap
8 8
9 from google.appengine.ext import ndb 9 from google.appengine.ext import ndb
10 10
11 from common.http_client_appengine import HttpClientAppengine as HttpClient 11 from common.http_client_appengine import HttpClientAppengine as HttpClient
12 from common.pipeline_wrapper import BasePipeline 12 from common.pipeline_wrapper import BasePipeline
13 from common.rietveld import Rietveld 13 from infra_api_clients.codereview.rietveld import Rietveld
14 from lib import time_util 14 from lib import time_util
15 from lib.gitiles.gitiles_repository import GitilesRepository 15 from lib.gitiles.gitiles_repository import GitilesRepository
16 from model import analysis_status as status 16 from model import analysis_status as status
17 from model.wf_analysis import WfAnalysis 17 from model.wf_analysis import WfAnalysis
18 from model.wf_culprit import WfCulprit 18 from model.wf_culprit import WfCulprit
19 from waterfall import build_util 19 from waterfall import build_util
20 from waterfall import waterfall_config 20 from waterfall import waterfall_config
21 21
22 22
23 def _AdditionalCriteriaAllPassed(additional_criteria): 23 def _AdditionalCriteriaAllPassed(additional_criteria):
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 'within_time_limit': within_time_limit 132 'within_time_limit': within_time_limit
133 } 133 }
134 134
135 if not _ShouldSendNotification( 135 if not _ShouldSendNotification(
136 master_name, builder_name, build_number, repo_name, 136 master_name, builder_name, build_number, repo_name,
137 revision, commit_position, build_num_threshold, additional_criteria, 137 revision, commit_position, build_num_threshold, additional_criteria,
138 send_notification_right_now): 138 send_notification_right_now):
139 return False 139 return False
140 return _SendNotificationForCulprit( 140 return _SendNotificationForCulprit(
141 repo_name, revision, commit_position, code_review_url) 141 repo_name, revision, commit_position, code_review_url)
OLDNEW
« no previous file with comments | « appengine/findit/predator/app/frontend/__init__.py ('k') | appengine/findit/waterfall/test/buildbot_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698