appengine/findit/predator/README.md - Issue 2488113005: [Findit] Re-org code.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/findit/predator/README.md

Issue 2488113005: [Findit] Re-org code. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Code structure

	2

	3 * [analysis](analysis): Core of analysis for Chrome crashes.
	wrengr 2016/11/10 21:20:35 -> "Core library for analyzing Chrome crashes." -> "Core library for analyzing Chrome crashes." stgao 2016/11/14 23:30:51 Done. Show quoted text On 2016/11/10 21:20:35, wrengr wrote: > -> "Core library for analyzing Chrome crashes." Done.
	4 * [app](app): The App Engine modules to provide core services of Predator.
	wrengr 2016/11/10 21:20:35 -> "The AppEngine application for invoking the lib -> "The AppEngine application for invoking the library to analyze Chrome crashes." Or something to that effect. The code under ./app isn't just "modules" but the whole AE application/client. Also, I think using "services" here is misleading, since that word has a technical meaning within AE. Plus, there isn't really a "core" set of analyses distinct from peripheral analyses. stgao 2016/11/14 23:30:51 Done. Removed "modules" and "services" as they mig Show quoted text On 2016/11/10 21:20:35, wrengr wrote: > -> "The AppEngine application for invoking the library to analyze Chrome > crashes." > > Or something to that effect. The code under ./app isn't just "modules" but the > whole AE application/client. Also, I think using "services" here is misleading, > since that word has a technical meaning within AE. Plus, there isn't really a > "core" set of analyses distinct from peripheral analyses. Done. Removed "modules" and "services" as they might be confusing especially both App Engine and Python have the concept "modules" while it has completely different meanings for them.
	5

	6 # Refactoring guideline

	7 * All core logic of analysis should live in [analysis](analysis), and it should

	8 be standalone, and not depend any App Engine APIs.

	9 * All app-layer code should live in [app](app)

	10 * Frontend code rendering UIs to providing APIs for clients like

	11 ClusterFuzz/Fracas/Cracas should live in [app/frontend](app/frontend).

	12 * Backend code running the analysis should live in [app/backend](app/backend).

	13 * Shared code between the frontend and backend should live in [app/common](app /common).

	14

	15 # Next step

	16 When the refactoring is done, we will do a one-off move to appengine/predator.

OLD	NEW

« appengine/findit/model/crash/crash_config.py ('K') | « appengine/findit/model/wf_config.py ('k') | appengine/findit/predator/__init__.py » ('j') | no next file with comments »