Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: components/metrics/profiler/tracking_synchronizer_unittest.cc

Issue 2488073002: Reuse ThreadData instances associated with terminated named threads. (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/profiler/tracking_synchronizer_unittest.cc
diff --git a/components/metrics/profiler/tracking_synchronizer_unittest.cc b/components/metrics/profiler/tracking_synchronizer_unittest.cc
index cae6cb208fe742e6687450244537f4add084b596..792d52f32bf2dfcba4e942fe02c8ebf9955d319a 100644
--- a/components/metrics/profiler/tracking_synchronizer_unittest.cc
+++ b/components/metrics/profiler/tracking_synchronizer_unittest.cc
@@ -69,8 +69,8 @@ class TestObserver : public TrackingSynchronizerObserver {
EXPECT_EQ(base::TimeTicks() + base::TimeDelta::FromMilliseconds(333),
attributes.phase_finish);
- EXPECT_EQ("death_thread0",
- process_data_phase.tasks[0].death_thread_name);
+ EXPECT_EQ("death_threadA",
+ process_data_phase.tasks[0].death_sanitized_thread_name);
EXPECT_EQ(0u, past_events.size());
break;
@@ -83,8 +83,8 @@ class TestObserver : public TrackingSynchronizerObserver {
EXPECT_EQ(base::TimeTicks() + base::TimeDelta::FromMilliseconds(777),
attributes.phase_finish);
- EXPECT_EQ("death_thread1",
- process_data_phase.tasks[0].death_thread_name);
+ EXPECT_EQ("death_threadB",
+ process_data_phase.tasks[0].death_sanitized_thread_name);
ASSERT_EQ(1u, past_events.size());
EXPECT_EQ(ProfilerEventProto::EVENT_FIRST_NONEMPTY_PAINT,
past_events[0]);
@@ -135,12 +135,12 @@ TEST(TrackingSynchronizerTest, ProfilerData) {
tracked_objects::ProcessDataSnapshot profiler_data;
ProcessDataPhaseSnapshot snapshot0;
tracked_objects::TaskSnapshot task_snapshot0;
- task_snapshot0.death_thread_name = "death_thread0";
+ task_snapshot0.death_sanitized_thread_name = "death_threadA";
snapshot0.tasks.push_back(task_snapshot0);
ProcessDataPhaseSnapshot snapshot1;
profiler_data.phased_snapshots[0] = snapshot0;
tracked_objects::TaskSnapshot task_snapshot1;
- task_snapshot1.death_thread_name = "death_thread1";
+ task_snapshot1.death_sanitized_thread_name = "death_threadB";
snapshot1.tasks.push_back(task_snapshot1);
profiler_data.phased_snapshots[1] = snapshot1;
profiler_data.process_id = 239;
« no previous file with comments | « components/metrics/profiler/profiler_metrics_provider_unittest.cc ('k') | content/common/child_process_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698