chrome/browser/task_profiler/task_profiler_data_serializer_unittest.cc - Issue 2488073002: Reuse ThreadData instances associated with terminated named threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_profiler/task_profiler_data_serializer_unittest.cc

Issue 2488073002: Reuse ThreadData instances associated with terminated named threads. (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/task_profiler/task_profiler_data_serializer.cc ('k') | components/metrics/profiler/profiler_metrics_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_profiler/task_profiler_data_serializer_unittest.cc

diff --git a/chrome/browser/task_profiler/task_profiler_data_serializer_unittest.cc b/chrome/browser/task_profiler/task_profiler_data_serializer_unittest.cc

index e248f1458ff0b82e9a6a150a987621f65fd0a81a..5ff71d6b3f60819d62a124d1d7e83e7d431acc89 100644

--- a/chrome/browser/task_profiler/task_profiler_data_serializer_unittest.cc

+++ b/chrome/browser/task_profiler/task_profiler_data_serializer_unittest.cc

@@ -54,14 +54,13 @@ TEST(TaskProfilerDataSerializerTest, SerializeProcessDataToJson) {

parent.location.file_name = "path/to/foo.cc";

parent.location.function_name = "WhizBang";

parent.location.line_number = 101;

- parent.thread_name = "CrBrowserMain";

+ parent.sanitized_thread_name = "CrBrowserMain";

tracked_objects::BirthOnThreadSnapshot child;

child.location.file_name = "path/to/bar.cc";

child.location.function_name = "FizzBoom";

child.location.line_number = 433;

- child.thread_name = "Chrome_IOThread";

+ child.sanitized_thread_name = "Chrome_IOThread";

// Add a snapshot.

process_data_phase.tasks.push_back(tracked_objects::TaskSnapshot());

@@ -79,7 +78,7 @@ TEST(TaskProfilerDataSerializerTest, SerializeProcessDataToJson) {

process_data_phase.tasks.back().death_data.freed_bytes = 1092;

process_data_phase.tasks.back().death_data.alloc_overhead_bytes = 201;

process_data_phase.tasks.back().death_data.max_allocated_bytes = 1500;

- process_data_phase.tasks.back().death_thread_name =

+ process_data_phase.tasks.back().death_sanitized_thread_name =

"WorkerPool/-1340960768";

// Add a second snapshot.

@@ -98,7 +97,8 @@ TEST(TaskProfilerDataSerializerTest, SerializeProcessDataToJson) {

process_data_phase.tasks.back().death_data.freed_bytes = 10092;

process_data_phase.tasks.back().death_data.alloc_overhead_bytes = 2001;

process_data_phase.tasks.back().death_data.max_allocated_bytes = 15000;

- process_data_phase.tasks.back().death_thread_name = "PAC thread #3";

+ process_data_phase.tasks.back().death_sanitized_thread_name =

+ "PAC thread #3";

ExpectSerialization(process_data_phase, 239,

metrics::ProfilerEventProto::TrackedObject::RENDERER,