components/metrics/profiler/profiler_metrics_provider_unittest.cc - Issue 2488073002: Reuse ThreadData instances associated with terminated named threads.

Unified Diff: components/metrics/profiler/profiler_metrics_provider_unittest.cc

Issue 2488073002: Reuse ThreadData instances associated with terminated named threads. (Closed)

Patch Set: CR danakj #55 (nits) Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/metrics/profiler/profiler_metrics_provider_unittest.cc

diff --git a/components/metrics/profiler/profiler_metrics_provider_unittest.cc b/components/metrics/profiler/profiler_metrics_provider_unittest.cc

index e2e31b922eb3260f2497f19304eaeda453f8eb34..fd5a62e55237f75e576e6eef539000a36a3fb471 100644

--- a/components/metrics/profiler/profiler_metrics_provider_unittest.cc

+++ b/components/metrics/profiler/profiler_metrics_provider_unittest.cc

@@ -45,7 +45,7 @@ TEST(ProfilerMetricsProviderTest, RecordData) {

process_data_phase.tasks.back().birth.location.file_name = "c\\d\\file2";

process_data_phase.tasks.back().birth.location.function_name = "function2";

process_data_phase.tasks.back().birth.location.line_number = 1773;

- process_data_phase.tasks.back().birth.thread_name = "birth_thread2";

+ process_data_phase.tasks.back().birth.thread_name = "birth_thread*";

process_data_phase.tasks.back().death_data.count = 19;

process_data_phase.tasks.back().death_data.run_duration_sum = 23;

process_data_phase.tasks.back().death_data.run_duration_max = 11;

@@ -82,7 +82,7 @@ TEST(ProfilerMetricsProviderTest, RecordData) {

process_data_phase.tasks.back().birth.location.function_name =

"function210";

process_data_phase.tasks.back().birth.location.line_number = 101773;

- process_data_phase.tasks.back().birth.thread_name = "birth_thread_ten2";

+ process_data_phase.tasks.back().birth.thread_name = "birth_thread_ten*";

process_data_phase.tasks.back().death_data.count = 1019;

process_data_phase.tasks.back().death_data.run_duration_sum = 1023;

process_data_phase.tasks.back().death_data.run_duration_max = 1011;

@@ -105,7 +105,7 @@ TEST(ProfilerMetricsProviderTest, RecordData) {

process_data_phase.tasks.back().birth.location.file_name = "file3";

process_data_phase.tasks.back().birth.location.function_name = "function3";

process_data_phase.tasks.back().birth.location.line_number = 7331;

- process_data_phase.tasks.back().birth.thread_name = "birth_thread3";

+ process_data_phase.tasks.back().birth.thread_name = "birth_thread*";

process_data_phase.tasks.back().death_data.count = 137;

process_data_phase.tasks.back().death_data.run_duration_sum = 131;

process_data_phase.tasks.back().death_data.run_duration_max = 117;

@@ -113,7 +113,7 @@ TEST(ProfilerMetricsProviderTest, RecordData) {

process_data_phase.tasks.back().death_data.queue_duration_sum = 108;

process_data_phase.tasks.back().death_data.queue_duration_max = 105;

process_data_phase.tasks.back().death_data.queue_duration_sample = 103;

- process_data_phase.tasks.back().death_thread_name = "death_thread3";

+ process_data_phase.tasks.back().death_thread_name = "death_thread*";

process_data_phase.tasks.push_back(TaskSnapshot());

process_data_phase.tasks.back().birth.location.file_name = "";

process_data_phase.tasks.back().birth.location.function_name = "";