Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2488043003: skpbench: filter out junk spewed by Pixel C driver (Closed)

Created:
4 years, 1 month ago by csmartdalton
Modified:
4 years, 1 month ago
Reviewers:
kjlubick
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

skpbench: filter out junk spewed by Pixel C driver BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2488043003 Committed: https://skia.googlesource.com/skia/+/f2b024db6777a904d986c68a21ba0bc41f956f6e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M tools/skpbench/_hardware.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/skpbench/_hardware_pixel_c.py View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/skpbench/skpbench.py View 4 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
csmartdalton
4 years, 1 month ago (2016-11-09 20:11:34 UTC) #3
kjlubick
Can you also add in the adb wait-for-device after the root here?
4 years, 1 month ago (2016-11-09 20:19:48 UTC) #4
kjlubick
lgtm
4 years, 1 month ago (2016-11-09 20:30:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488043003/1
4 years, 1 month ago (2016-11-09 20:37:13 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 21:25:33 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f2b024db6777a904d986c68a21ba0bc41f956f6e

Powered by Google App Engine
This is Rietveld 408576698