Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2488013003: [android] Tweak data deps to include two chromium tool binaries. (Closed)

Created:
4 years, 1 month ago by jbudorick
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[android] Tweak data deps to include two chromium tool binaries. This includes: - //tools/android/md5sum:md5sum_bin($host_toolchain) -- we had previously only depended on the symlink, not the target thereof - //build/android/pylib/device/commands -- we previously only had it set as a dependency of the forwarder & incremental APKs This should prevent bots running chromium tests from downloading the devil versions stored in GS. BUG=664211 Committed: https://crrev.com/459473d91b7a627024b3dbf016fa599b79c13845 Cr-Commit-Position: refs/heads/master@{#431378}

Patch Set 1 #

Patch Set 2 : fixed? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M build/android/pylib/device/commands/BUILD.gn View 1 1 chunk +5 lines, -2 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/android/rules.gni View 1 2 chunks +5 lines, -2 lines 0 comments Download
M build/symlink.gni View 1 2 chunks +5 lines, -1 line 0 comments Download
M tools/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
jbudorick
4 years, 1 month ago (2016-11-10 21:29:07 UTC) #8
Dirk Pranke
lgtm
4 years, 1 month ago (2016-11-10 22:17:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488013003/20001
4 years, 1 month ago (2016-11-10 22:18:42 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-10 22:24:00 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/459473d91b7a627024b3dbf016fa599b79c13845 Cr-Commit-Position: refs/heads/master@{#431378}
4 years, 1 month ago (2016-11-10 23:10:16 UTC) #16
Tobias Sargeant
4 years, 1 month ago (2016-11-11 13:08:34 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2488353003/ by tobiasjs@chromium.org.

The reason for reverting is: Causes dump_syms not to be built, official build
bots failing.

https://bugs.chromium.org/p/chromium/issues/detail?id=664423&q=dump_syms&cols....

Powered by Google App Engine
This is Rietveld 408576698