Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2488003002:
[Tracing] Fix crash of --enable-tracing. (Closed)
Description[Tracing] Fix crash of --enable-tracing.
When we use unique_ptr on tracing controller and release it to platform,
unique_ptr will crash when we try to start tracing with trace config, this patch
replaces it with raw pointer and delete it explicitly at the end when needed.
TBR=yangguo@chromium.org
Committed: https://crrev.com/bc37b518e4c654ff5ab419db1b726b31af8c9532
Cr-Commit-Position: refs/heads/master@{#40871}
Patch Set 1 #Messages
Total messages: 18 (11 generated)
The CQ bit was checked by lpy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lpy@chromium.org changed reviewers: + fmeawad@chromium.org
ptal
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by lpy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/28182)
Description was changed from ========== [Tracing] Fix crash of --enable-tracing. When we use unique_ptr on tracing controller and release it to platform, unique_ptr will crash when we try to start tracing with trace config, this patch replaces it with raw pointer and delete it explicitly at the end when needed. ========== to ========== [Tracing] Fix crash of --enable-tracing. When we use unique_ptr on tracing controller and release it to platform, unique_ptr will crash when we try to start tracing with trace config, this patch replaces it with raw pointer and delete it explicitly at the end when needed. TBR=yangguo@chromium.org ==========
The CQ bit was checked by lpy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Tracing] Fix crash of --enable-tracing. When we use unique_ptr on tracing controller and release it to platform, unique_ptr will crash when we try to start tracing with trace config, this patch replaces it with raw pointer and delete it explicitly at the end when needed. TBR=yangguo@chromium.org ========== to ========== [Tracing] Fix crash of --enable-tracing. When we use unique_ptr on tracing controller and release it to platform, unique_ptr will crash when we try to start tracing with trace config, this patch replaces it with raw pointer and delete it explicitly at the end when needed. TBR=yangguo@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Tracing] Fix crash of --enable-tracing. When we use unique_ptr on tracing controller and release it to platform, unique_ptr will crash when we try to start tracing with trace config, this patch replaces it with raw pointer and delete it explicitly at the end when needed. TBR=yangguo@chromium.org ========== to ========== [Tracing] Fix crash of --enable-tracing. When we use unique_ptr on tracing controller and release it to platform, unique_ptr will crash when we try to start tracing with trace config, this patch replaces it with raw pointer and delete it explicitly at the end when needed. TBR=yangguo@chromium.org Committed: https://crrev.com/bc37b518e4c654ff5ab419db1b726b31af8c9532 Cr-Commit-Position: refs/heads/master@{#40871} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/bc37b518e4c654ff5ab419db1b726b31af8c9532 Cr-Commit-Position: refs/heads/master@{#40871} |
