Part 2.3: Is policy list subsumed under subsuming policy?

third_party/WebKit/Source/core/frame/csp/CSPSourceTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/frame/csp/CSPSource.h"
 
 #include "core/dom/Document.h"
 #include "core/frame/csp/ContentSecurityPolicy.h"
 #include "platform/network/ResourceRequest.h"
 #include "platform/weborigin/KURL.h"
 #include "platform/weborigin/SecurityOrigin.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace blink {
 
 class CSPSourceTest : public ::testing::Test {
  public:
   CSPSourceTest() : csp(ContentSecurityPolicy::create()) {}
 
  protected:
   Persistent<ContentSecurityPolicy> csp;
+  struct Source {
+    String scheme;
+    String host;
+    String path;
+    const int port;

[Mike West, 2016/11/24 14:00:54]

Nit: Can you add a comment about the meaning of `0`?

[amalika, 2016/11/24 14:50:33]

Added!

+    CSPSource::WildcardDisposition hostWildcard;
+    CSPSource::WildcardDisposition portWildcard;
+  };
+
+  bool equalSources(const Source& a, const Source& b) {
+    return a.scheme == b.scheme && a.host == b.host && a.port == b.port &&
+           a.path == b.path && a.hostWildcard == b.hostWildcard &&
+           a.portWildcard == b.portWildcard;
+  }
 };
 
 TEST_F(CSPSourceTest, BasicMatching) {
   KURL base;
   CSPSource source(csp.get(), "http", "example.com", 8000, "/foo/",
                    CSPSource::NoWildcard, CSPSource::NoWildcard);
 
   EXPECT_TRUE(source.matches(KURL(base, "http://example.com:8000/foo/")));
   EXPECT_TRUE(source.matches(KURL(base, "http://example.com:8000/foo/bar")));
   EXPECT_TRUE(source.matches(KURL(base, "HTTP://EXAMPLE.com:8000/foo/BAR")));
@@ skipping 501 matching lines @@
     listB.append(httpsOnly);
     EXPECT_FALSE(CSPSource::firstSubsumesSecond(listA, listB));
 
     // If we add a scheme-source expression of 'http' to `listA`, then it should
     // subsume all current epxression in `listB`.
     listA.append(httpOnly);
     EXPECT_TRUE(CSPSource::firstSubsumesSecond(listA, listB));
   }
 }
 
+TEST_F(CSPSourceTest, Intersect) {
+  struct TestCase {
+    const Source a;
+    const Source b;
+    const Source normalized;
+  } cases[] = {
+      {{"http", "example.com", "/", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard},
+       {"http", "example.com", "/", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard},
+       {"http", "example.com", "/", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard}},
+      {{"ws", "example.com", "/", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard},
+       {"wss", "example.com", "/", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard},
+       {"wss", "example.com", "/", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard}},
+      // Wildcards
+      {{"http", "example.com", "/", 0, CSPSource::HasWildcard,
+        CSPSource::NoWildcard},
+       {"http", "example.com", "/", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard},
+       {"http", "example.com", "/", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard}},
+      {{"http", "example.com", "/", 0, CSPSource::HasWildcard,
+        CSPSource::HasWildcard},
+       {"http", "example.com", "/", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard},
+       {"http", "example.com", "/", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard}},
+      {{"http", "example.com", "/", 0, CSPSource::HasWildcard,
+        CSPSource::NoWildcard},
+       {"http", "example.com", "/", 0, CSPSource::NoWildcard,
+        CSPSource::HasWildcard},
+       {"http", "example.com", "/", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard}},
+      // Ports
+      {{"http", "example.com", "/", 80, CSPSource::NoWildcard,
+        CSPSource::NoWildcard},
+       {"http", "example.com", "/", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard},
+       {"http", "example.com", "/", 80, CSPSource::NoWildcard,
+        CSPSource::NoWildcard}},
+      // Paths
+      {{"http", "example.com", "/", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard},
+       {"http", "example.com", "/1.html", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard},
+       {"http", "example.com", "/1.html", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard}},
+      {{"http", "example.com", "/", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard},
+       {"http", "example.com", "", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard},
+       {"http", "example.com", "/", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard}},
+      {{"http", "example.com", "/", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard},
+       {"http", "example.com", "/a/b/", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard},
+       {"http", "example.com", "/a/b/", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard}},
+      {{"http", "example.com", "/a/", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard},
+       {"http", "example.com", "/a/b/", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard},
+       {"http", "example.com", "/a/b/", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard}},
+      {{"http", "example.com", "/a/", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard},
+       {"http", "example.com", "/a/b/1.html", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard},
+       {"http", "example.com", "/a/b/1.html", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard}},
+      // Mixed
+      {{"http", "example.com", "/1.html", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard},
+       {"http", "example.com", "/", 80, CSPSource::NoWildcard,
+        CSPSource::NoWildcard},
+       {"http", "example.com", "/1.html", 80, CSPSource::NoWildcard,
+        CSPSource::NoWildcard}},
+  };
+
+  for (const auto& test : cases) {
+    CSPSource* A =
+        new CSPSource(csp.get(), test.a.scheme, test.a.host, test.a.port,
+                      test.a.path, test.a.hostWildcard, test.a.portWildcard);
+    CSPSource* B =
+        new CSPSource(csp.get(), test.b.scheme, test.b.host, test.b.port,
+                      test.b.path, test.b.hostWildcard, test.b.portWildcard);
+
+    CSPSource* normalized = A->intersect(B);
+    Source intersectAB = {
+        normalized->m_scheme,       normalized->m_host,
+        normalized->m_path,         normalized->m_port,
+        normalized->m_hostWildcard, normalized->m_portWildcard};
+    EXPECT_TRUE(equalSources(intersectAB, test.normalized));
+
+    // Verify the same test with A and B swapped. The result should be
+    // identical.
+    normalized = B->intersect(A);
+    Source intersectBA = {
+        normalized->m_scheme,       normalized->m_host,
+        normalized->m_path,         normalized->m_port,
+        normalized->m_hostWildcard, normalized->m_portWildcard};
+    EXPECT_TRUE(equalSources(intersectBA, test.normalized));
+  }
+}
+
+TEST_F(CSPSourceTest, IntersectSchemesOnly) {
+  struct TestCase {
+    const Source a;
+    const Source b;
+    const Source normalized;
+  } cases[] = {
+      // Both sources are schemes only.
+      {{"http", "", "", 0, CSPSource::NoWildcard, CSPSource::NoWildcard},
+       {"http", "", "", 0, CSPSource::NoWildcard, CSPSource::NoWildcard},
+       {"http", "", "", 0, CSPSource::NoWildcard, CSPSource::NoWildcard}},
+      {{"http", "", "", 0, CSPSource::NoWildcard, CSPSource::NoWildcard},
+       {"https", "", "", 0, CSPSource::NoWildcard, CSPSource::NoWildcard},
+       {"https", "", "", 0, CSPSource::NoWildcard, CSPSource::NoWildcard}},
+      {{"ws", "", "", 0, CSPSource::NoWildcard, CSPSource::NoWildcard},
+       {"wss", "", "", 0, CSPSource::NoWildcard, CSPSource::NoWildcard},
+       {"wss", "", "", 0, CSPSource::NoWildcard, CSPSource::NoWildcard}},
+      // One source is a scheme only and the other one has no wildcards.
+      {{"http", "", "", 0, CSPSource::NoWildcard, CSPSource::NoWildcard},
+       {"http", "example.com", "/", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard},
+       {"http", "example.com", "/", 0, CSPSource::NoWildcard,
+        CSPSource::NoWildcard}},
+      {{"http", "", "", 0, CSPSource::NoWildcard, CSPSource::NoWildcard},
+       {"https", "example.com", "/", 80, CSPSource::NoWildcard,
+        CSPSource::NoWildcard},
+       {"https", "example.com", "/", 80, CSPSource::NoWildcard,
+        CSPSource::NoWildcard}},
+      {{"https", "", "", 0, CSPSource::NoWildcard, CSPSource::NoWildcard},
+       {"http", "example.com", "/page.html", 80, CSPSource::NoWildcard,
+        CSPSource::NoWildcard},
+       {"https", "example.com", "/page.html", 80, CSPSource::NoWildcard,
+        CSPSource::NoWildcard}},
+      // One source is a scheme only and the other has one or two wildcards.
+      {{"https", "", "", 0, CSPSource::NoWildcard, CSPSource::NoWildcard},
+       {"http", "example.com", "/page.html", 80, CSPSource::HasWildcard,
+        CSPSource::NoWildcard},
+       {"https", "example.com", "/page.html", 80, CSPSource::HasWildcard,
+        CSPSource::NoWildcard}},
+      {{"https", "", "", 0, CSPSource::NoWildcard, CSPSource::NoWildcard},
+       {"http", "example.com", "/page.html", 80, CSPSource::NoWildcard,
+        CSPSource::HasWildcard},
+       {"https", "example.com", "/page.html", 80, CSPSource::NoWildcard,
+        CSPSource::HasWildcard}},
+      {{"https", "", "", 0, CSPSource::NoWildcard, CSPSource::NoWildcard},
+       {"http", "example.com", "/page.html", 80, CSPSource::HasWildcard,
+        CSPSource::HasWildcard},
+       {"https", "example.com", "/page.html", 80, CSPSource::HasWildcard,
+        CSPSource::HasWildcard}},
+  };
+
+  for (const auto& test : cases) {
+    CSPSource* A =
+        new CSPSource(csp.get(), test.a.scheme, test.a.host, test.a.port,
+                      test.a.path, test.a.hostWildcard, test.a.portWildcard);
+
+    CSPSource* B =
+        new CSPSource(csp.get(), test.b.scheme, test.b.host, test.b.port,
+                      test.b.path, test.b.hostWildcard, test.b.portWildcard);
+
+    CSPSource* normalized = A->intersect(B);
+    Source intersectAB = {
+        normalized->m_scheme,       normalized->m_host,
+        normalized->m_path,         normalized->m_port,
+        normalized->m_hostWildcard, normalized->m_portWildcard};
+    EXPECT_TRUE(equalSources(intersectAB, test.normalized));
+
+    // Verify the same test with A and B swapped. The result should be
+    // identical.
+    normalized = B->intersect(A);
+    Source intersectBA = {
+        normalized->m_scheme,       normalized->m_host,
+        normalized->m_path,         normalized->m_port,
+        normalized->m_hostWildcard, normalized->m_portWildcard};
+    EXPECT_TRUE(equalSources(intersectBA, test.normalized));
+  }
+}
+
 }  // namespace blink