Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2487973003: GOAWAY open QUIC sessions if clock skew is detected (Closed)

Created:
4 years, 1 month ago by Ryan Hamilton
Modified:
4 years, 1 month ago
Reviewers:
Buck
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GOAWAY open QUIC sessions if clock skew is detected Committed: https://crrev.com/f11cc0ff41a479c2a57214c77ae179ab2b9f9d44 Cr-Commit-Position: refs/heads/master@{#432065}

Patch Set 1 #

Patch Set 2 : Fix iteration #

Patch Set 3 : format #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -1 line) Patch
M net/net.gypi View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
A net/quic/chromium/quic_clock_skew_detector.h View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A net/quic/chromium/quic_clock_skew_detector.cc View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
A net/quic/chromium/quic_clock_skew_detector_test.cc View 1 2 1 chunk +69 lines, -0 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.cc View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M net/quic/core/quic_session.cc View 1 2 1 chunk +0 lines, -1 line 2 comments Download

Messages

Total messages: 10 (4 generated)
Ryan Hamilton
4 years, 1 month ago (2016-11-14 23:46:46 UTC) #3
Buck
lgtm https://codereview.chromium.org/2487973003/diff/40001/net/quic/core/quic_session.cc File net/quic/core/quic_session.cc (left): https://codereview.chromium.org/2487973003/diff/40001/net/quic/core/quic_session.cc#oldcode16 net/quic/core/quic_session.cc:16: #include "net/ssl/ssl_info.h" No harm in removing dead code, ...
4 years, 1 month ago (2016-11-14 23:49:46 UTC) #4
Ryan Hamilton
Thanks! https://codereview.chromium.org/2487973003/diff/40001/net/quic/core/quic_session.cc File net/quic/core/quic_session.cc (left): https://codereview.chromium.org/2487973003/diff/40001/net/quic/core/quic_session.cc#oldcode16 net/quic/core/quic_session.cc:16: #include "net/ssl/ssl_info.h" On 2016/11/14 23:49:46, Buck wrote: > ...
4 years, 1 month ago (2016-11-14 23:50:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487973003/40001
4 years, 1 month ago (2016-11-14 23:52:30 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-15 03:05:04 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 03:08:20 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/f11cc0ff41a479c2a57214c77ae179ab2b9f9d44
Cr-Commit-Position: refs/heads/master@{#432065}

Powered by Google App Engine
This is Rietveld 408576698