Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2487973002: Disable maps_pixel_test on Mac and Win (Closed)

Created:
4 years, 1 month ago by vabr (Chromium)
Modified:
4 years, 1 month ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable maps_pixel_test on Mac and Win The test is flaky on Mac 10.10 Debug(Intel) and Win7 Release (NVIDIA). BUG=626986 TBR=vmiura@chromium.org,kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/8cf7cb095499c4627228940c2ab0d07aba839d4f Cr-Commit-Position: refs/heads/master@{#430934}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M content/test/gpu/generate_buildbot_json.py View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487973002/1
4 years, 1 month ago (2016-11-09 14:25:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 15:24:43 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8cf7cb095499c4627228940c2ab0d07aba839d4f Cr-Commit-Position: refs/heads/master@{#430934}
4 years, 1 month ago (2016-11-09 15:26:35 UTC) #6
Ken Russell (switch to Gerrit)
4 years, 1 month ago (2016-11-09 18:24:10 UTC) #7
Message was sent while issue was closed.
On 2016/11/09 15:26:35, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/8cf7cb095499c4627228940c2ab0d07aba839d4f
> Cr-Commit-Position: refs/heads/master@{#430934}

FYI, this had no effect -- it wasn't the correct way of doing this disable. In
order for it to plausibly have any effect this generator script would have had
to be run and the changes in src/testing/buildbot/ checked in too. Regardless,
the test should have been marked flaky so I've reverted this change and done
that in https://codereview.chromium.org/2487093003/ .

Powered by Google App Engine
This is Rietveld 408576698