chrome/browser/ui/ash/launcher/launcher_item_controller.h - Issue 2487953003: Remove LauncherItemController::IsOpen, check ShelfItem::status.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/launcher_item_controller.h

Issue 2487953003: Remove LauncherItemController::IsOpen, check ShelfItem::status. (Closed)

Patch Set: Address comments. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/ash/launcher/launcher_item_controller.h

diff --git a/chrome/browser/ui/ash/launcher/launcher_item_controller.h b/chrome/browser/ui/ash/launcher/launcher_item_controller.h

index 42b55b838b65b9d6d8281e0b196177f49795ab6b..74d9a6ff665877e977072564c876e22b1e700dab 100644

--- a/chrome/browser/ui/ash/launcher/launcher_item_controller.h

+++ b/chrome/browser/ui/ash/launcher/launcher_item_controller.h

@@ -68,9 +68,6 @@ class LauncherItemController : public ash::ShelfItemDelegate {

image_set_by_controller_ = image_set_by_controller;

}

- // Returns true if this item is open.

- virtual bool IsOpen() const = 0;

// Returns true if this item is visible (e.g. not minimized).

virtual bool IsVisible() const = 0;