chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.h - Issue 2487953003: Remove LauncherItemController::IsOpen, check ShelfItem::status.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.h

Issue 2487953003: Remove LauncherItemController::IsOpen, check ShelfItem::status. (Closed)

Patch Set: Address comments. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc ('k') | chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.h

diff --git a/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.h b/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.h

index 1c13bc461fe084bd9697967630001bf705670747..d732f593b0a97dc542d9535ce0338826533e3f0c 100644

--- a/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.h

+++ b/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.h

@@ -43,7 +43,6 @@ class BrowserShortcutLauncherItemController : public LauncherItemController {

bool IsListOfActiveBrowserEmpty();

// LauncherItemController overrides:

- bool IsOpen() const override;

bool IsVisible() const override;

void Launch(ash::LaunchSource source, int event_flags) override;

ShelfItemDelegate::PerformedAction Activate(