Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2848)

Unified Diff: chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc

Issue 2487953003: Remove LauncherItemController::IsOpen, check ShelfItem::status. (Closed)
Patch Set: Cleanup. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc
diff --git a/chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc b/chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc
index 7c560b490f829f2251c8f3bf1b0fab7d9a81cff9..f198434330dc1271768a5df2fa7a469796b1ef6e 100644
--- a/chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc
+++ b/chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc
@@ -361,3 +361,17 @@ IN_PROC_BROWSER_TEST_F(ArcAppLauncherBrowserTest, AppListShown) {
SendPackageAdded(true);
EXPECT_FALSE(app_list_service->IsAppListVisible());
}
+
+// Test AppListControllerDelegate::IsAppOpen for Arc apps.
+IN_PROC_BROWSER_TEST_F(ArcAppLauncherBrowserTest, IsAppOpen) {
+ StartInstance();
+ InstallTestApps(false);
+ SendPackageAdded(true);
+ const std::string app_id = GetTestApp1Id();
+
+ AppListService* service = AppListService::Get();
+ AppListControllerDelegate* delegate = service->GetControllerDelegate();
+ EXPECT_FALSE(delegate->IsAppOpen(app_id));
+ arc::LaunchApp(profile(), app_id);
+ EXPECT_FALSE(delegate->IsAppOpen(app_id));
khmel 2016/11/10 01:31:26 Should not it be EXPECT_TRUE()?
msw 2016/11/10 02:39:10 You're right; good catch! Fixed with a fake task c
+}

Powered by Google App Engine
This is Rietveld 408576698