Remove LauncherItemController::IsOpen, check ShelfItem::status.

chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h"
 
 #include <stddef.h>
 
 #include "ash/aura/wm_window_aura.h"
 #include "ash/common/shelf/app_list_button.h"
@@ skipping 2081 matching lines @@
   generator.ClickLeftButton();
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(tab_count + 1, tab_strip->count());
 }
 
 // Check LauncherItemController of Browser Shortcut functionality.
 IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTestNoDefaultBrowser,
                        BrowserShortcutLauncherItemController) {
   LauncherItemController* item_controller =
       controller_->GetBrowserShortcutLauncherItemController();
+  const ash::ShelfID id = item_controller->shelf_id();
+  EXPECT_NE(ash::kInvalidShelfID, id);
 
   // Get the number of browsers.
   size_t running_browser = chrome::GetTotalBrowserCount();
   EXPECT_EQ(0u, running_browser);
-  EXPECT_FALSE(item_controller->IsOpen());
+  EXPECT_FALSE(controller_->IsOpen(id));
 
   // Activate. This creates new browser
   item_controller->Activate(ash::LAUNCH_FROM_UNKNOWN);
   // New Window is created.
   running_browser = chrome::GetTotalBrowserCount();
   EXPECT_EQ(1u, running_browser);
-  EXPECT_TRUE(item_controller->IsOpen());
+  EXPECT_TRUE(controller_->IsOpen(id));
 
   // Minimize Window.
   ash::wm::WindowState* window_state = ash::wm::GetActiveWindowState();
   window_state->Minimize();
   EXPECT_TRUE(window_state->IsMinimized());
 
   // Activate again. This doesn't create new browser.
   // It activates window.
   item_controller->Activate(ash::LAUNCH_FROM_UNKNOWN);
   running_browser = chrome::GetTotalBrowserCount();
   EXPECT_EQ(1u, running_browser);
-  EXPECT_TRUE(item_controller->IsOpen());
+  EXPECT_TRUE(controller_->IsOpen(id));
   EXPECT_FALSE(window_state->IsMinimized());
 }
 
 // Check that the window's ShelfID property matches that of the active tab.
 IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, MatchingShelfIDandActiveTab) {
   EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
   EXPECT_EQ(1, browser()->tab_strip_model()->count());
   EXPECT_EQ(0, browser()->tab_strip_model()->active_index());
   EXPECT_EQ(2, model_->item_count());
 
@@ skipping 232 matching lines @@
 
   // Close all windows via the menu item.
   CloseBrowserWindow(browser(), menu1.get(), LauncherContextMenu::MENU_CLOSE);
   EXPECT_EQ(0u, BrowserList::GetInstance()->size());
 
   // Check if "Close" is removed from the context menu.
   std::unique_ptr<LauncherContextMenu> menu2 = CreateBrowserItemContextMenu();
   ASSERT_FALSE(
       IsItemPresentInMenu(menu2.get(), LauncherContextMenu::MENU_CLOSE));
 }