Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2487943005: [stubs] Fix CodeStubAssembler::TrapAllocationMemento (Closed)

Created:
4 years, 1 month ago by Jakob Kummerow
Modified:
4 years, 1 month ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Fix CodeStubAssembler::TrapAllocationMemento to actually trap allocation mementos. Committed: https://crrev.com/cc2a2771a6c7712375abef23e9153819caf4e9af Cr-Commit-Position: refs/heads/master@{#40895}

Patch Set 1 #

Patch Set 2 : fix test for --always-opt #

Patch Set 3 : use a bigger hammer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -9 lines) Patch
M src/code-stub-assembler.cc View 1 chunk +9 lines, -9 lines 0 comments Download
A test/mjsunit/regress/regress-trap-allocation-memento.js View 1 2 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Jakob Kummerow
PTAL.
4 years, 1 month ago (2016-11-10 12:24:42 UTC) #2
Igor Sheludko
lgtm, thanks!
4 years, 1 month ago (2016-11-10 12:26:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487943005/1
4 years, 1 month ago (2016-11-10 12:27:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/7658) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 1 month ago (2016-11-10 12:40:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487943005/20001
4 years, 1 month ago (2016-11-10 12:54:55 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/7661) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 1 month ago (2016-11-10 13:09:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487943005/40001
4 years, 1 month ago (2016-11-10 13:19:51 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-10 13:47:04 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:29:19 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cc2a2771a6c7712375abef23e9153819caf4e9af
Cr-Commit-Position: refs/heads/master@{#40895}

Powered by Google App Engine
This is Rietveld 408576698