Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2487943002: Revert of Reenable media-device enumeration integration test. (Closed)

Created:
4 years, 1 month ago by Guido Urdaneta
Modified:
4 years, 1 month ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, phoglund+watch_chromium.org, mcasas+watch+vc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reenable media-device enumeration integration test. (patchset #3 id:40001 of https://codereview.chromium.org/2472593004/ ) Reason for revert: Temporary revert due to another CL prior to this one breaking some perf tests. See crbug.com/662414 Original issue's description: > Reenable media-device enumeration integration test. > > Updated to use enumerateDevices and remove references to > MediaStreamTrack.getSources(). > > BUG=388194 > > Committed: https://crrev.com/eae01dae1bee162c20ee9e21b6b542603b346cd3 > Cr-Commit-Position: refs/heads/master@{#430240} TBR=hbos@chromium.org,phoglund@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=388194 Committed: https://crrev.com/95e933c6b94f906043bce4815116cb3b217f1a43 Cr-Commit-Position: refs/heads/master@{#430923}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -36 lines) Patch
M chrome/browser/media/webrtc/webrtc_getmediadevices_browsertest.cc View 9 chunks +153 lines, -35 lines 0 comments Download
M chrome/test/data/webrtc/media_devices.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Guido Urdaneta
Created Revert of Reenable media-device enumeration integration test.
4 years, 1 month ago (2016-11-09 12:31:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487943002/1
4 years, 1 month ago (2016-11-09 12:31:57 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 13:49:48 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/95e933c6b94f906043bce4815116cb3b217f1a43 Cr-Commit-Position: refs/heads/master@{#430923}
4 years, 1 month ago (2016-11-09 13:51:45 UTC) #7
phoglund_chromium
lgtm
4 years, 1 month ago (2016-11-09 15:20:05 UTC) #8
Guido Urdaneta
4 years, 1 month ago (2016-11-11 13:47:12 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2492213002/ by guidou@chromium.org.

The reason for reverting is: Revert no longer necessary..

Powered by Google App Engine
This is Rietveld 408576698