Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2487913004: Add MSA optimized ARGBToRGB24Row_MSA and ARGBToRAWRow_MSA functions (Closed)

Created:
4 years, 1 month ago by manojkumar.bhosale
Modified:
4 years, 1 month ago
CC:
gordana.cmiljanovic_imgtec.com, raghu.gandham_imgtec.com, parag.salasakar_imgtec.com, mandar.sahastrabuddhe_imgtec.com, rob.isherwood_imgtec.com
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Add MSA optimized ARGBToRGB24Row_MSA and ARGBToRAWRow_MSA functions R=fbarchard@google.com BUG=libyuv:634 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/b1504a8e48acbb0d1fee6f1c0fe3851ab71348fb

Patch Set 1 #

Patch Set 2 : Changes as per coding guidelines #

Patch Set 3 : Changes as per coding guidelines #

Patch Set 4 : Added missed code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -18 lines) Patch
M include/libyuv/row.h View 1 2 3 3 chunks +6 lines, -0 lines 0 comments Download
M source/convert_from_argb.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M source/row_any.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M source/row_msa.cc View 1 2 4 chunks +66 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
manojkumar.bhosale
4 years, 1 month ago (2016-11-10 10:46:38 UTC) #1
manojkumar.bhosale
4 years, 1 month ago (2016-11-10 15:41:51 UTC) #4
manojkumar.bhosale
On 2016/11/10 15:41:51, manojkumar.bhosale wrote: Any update on this?
4 years, 1 month ago (2016-11-17 10:25:34 UTC) #5
fbarchard1
lgtm
4 years, 1 month ago (2016-11-18 23:00:02 UTC) #6
fbarchard1
Committed patchset #4 (id:60001) manually as b1504a8e48acbb0d1fee6f1c0fe3851ab71348fb (presubmit successful).
4 years, 1 month ago (2016-11-18 23:05:14 UTC) #8
fbarchard1
4 years, 1 month ago (2016-11-18 23:08:36 UTC) #9
Message was sent while issue was closed. 
looks good, thanks!
ran clang-format on it and submitted.

All RGB formats have conversion to/from ARGB.
All YUV formats have conversion to/from I420.
An arbitrary YUV to RGB conversion can be done with 3 steps
1. YUV to I420
2. I420 to ARGB
3. ARGB to RGB
Done a row at a time, this can be relatively efficient and requires less code
than doing all permutations.
ARGB is the most common format on all platforms, except android, which is
typically ABGR.

Powered by Google App Engine
This is Rietveld 408576698