Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 2487893005: Fix WebApkValidator#isValidWebApk() on Android N (Closed)

Created:
4 years, 1 month ago by pkotwicz
Modified:
4 years, 1 month ago
Reviewers:
gone
CC:
chromium-reviews, zpeng+watch_chromium.org, Xi Han
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix WebApkValidator#isValidWebApk() on Android N On Android N, the order of the signatures is reversed BUG=663937 Committed: https://crrev.com/6a0bcdf0275259958111359d92d8d102126b828d Cr-Commit-Position: refs/heads/master@{#431095}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
pkotwicz
Dan, can you please take a look? I haven't found any documentation documenting this discrepency
4 years, 1 month ago (2016-11-09 23:17:51 UTC) #3
gone
lgtm
4 years, 1 month ago (2016-11-09 23:21:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487893005/1
4 years, 1 month ago (2016-11-09 23:23:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 00:27:47 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 00:38:14 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a0bcdf0275259958111359d92d8d102126b828d
Cr-Commit-Position: refs/heads/master@{#431095}

Powered by Google App Engine
This is Rietveld 408576698