Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Unified Diff: net/nqe/network_qualities_prefs_manager_unittest.cc

Issue 2487883002: NQE: Use cached estimates (Closed)
Patch Set: Rebased, ryansturm comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/nqe/network_qualities_prefs_manager_unittest.cc
diff --git a/net/nqe/network_qualities_prefs_manager_unittest.cc b/net/nqe/network_qualities_prefs_manager_unittest.cc
index a171bb02708049589c0e4aea8484cdc9a3c884a2..c25d43c13d18e86a7b9350d1ff4e4c2b05206ec7 100644
--- a/net/nqe/network_qualities_prefs_manager_unittest.cc
+++ b/net/nqe/network_qualities_prefs_manager_unittest.cc
@@ -9,6 +9,7 @@
#include "base/macros.h"
#include "base/run_loop.h"
+#include "base/test/histogram_tester.h"
#include "base/threading/thread_checker.h"
#include "base/values.h"
#include "net/base/network_change_notifier.h"
@@ -40,11 +41,11 @@ class TestPrefDelegate : public NetworkQualitiesPrefsManager::PrefDelegate {
ASSERT_EQ(value.size(), value_->size());
}
- const base::DictionaryValue& GetDictionaryValue() override {
+ std::unique_ptr<base::DictionaryValue> GetDictionaryValue() override {
DCHECK(thread_checker_.CalledOnValidThread());
read_count_++;
- return *(value_.get());
+ return value_->CreateDeepCopy();
}
size_t write_count() const {
@@ -225,6 +226,11 @@ TEST(NetworkQualitiesPrefManager, WriteAndReadWithMultipleNetworkIDs) {
NOTREACHED();
}
}
+
+ base::HistogramTester histogram_tester;
+ estimator.OnPrefsRead(read_prefs);
+ histogram_tester.ExpectUniqueSample("NQE.Prefs.ReadSize", 3, 1);
+
manager.ShutdownOnPrefThread();
}

Powered by Google App Engine
This is Rietveld 408576698