Speculate on bitwise operators.

runtime/vm/intermediate_language_x64.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/intermediate_language.h"
 
 #include "vm/compiler.h"
@@ skipping 2861 matching lines @@
   }
 
  private:
   CheckedSmiOpInstr* instruction_;
   intptr_t try_index_;
 };
 
 
 LocationSummary* CheckedSmiOpInstr::MakeLocationSummary(Zone* zone,
                                                         bool opt) const {
+  bool is_shift = (op_kind() == Token::kSHL) || (op_kind() == Token::kSHR);
   const intptr_t kNumInputs = 2;
-  const intptr_t kNumTemps = 0;
+  const intptr_t kNumTemps = is_shift ? 1 : 0;
   LocationSummary* summary = new(zone) LocationSummary(
       zone, kNumInputs, kNumTemps, LocationSummary::kCallOnSlowPath);
   summary->set_in(0, Location::RequiresRegister());
   summary->set_in(1, Location::RequiresRegister());
   switch (op_kind()) {
     case Token::kADD:
     case Token::kSUB:
     case Token::kMUL:
+    case Token::kSHL:
+    case Token::kSHR:
       summary->set_out(0, Location::RequiresRegister());
       break;
     case Token::kBIT_OR:
     case Token::kBIT_AND:
     case Token::kBIT_XOR:
       summary->set_out(0, Location::SameAsFirstInput());
       break;
     default:
       UNIMPLEMENTED();
   }
+  if (is_shift) {
+    summary->set_temp(0, Location::RegisterLocation(RCX));
+  }
   return summary;
 }
 
 
 void CheckedSmiOpInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   CheckedSmiSlowPath* slow_path =
       new CheckedSmiSlowPath(this, compiler->CurrentTryIndex());
   compiler->AddSlowPathCode(slow_path);
   // Test operands if necessary.
 
@@ skipping 36 matching lines @@
       __ orq(result, right);
       break;
     case Token::kBIT_AND:
       ASSERT(left == result);
       __ andq(result, right);
       break;
     case Token::kBIT_XOR:
       ASSERT(left == result);
       __ xorq(result, right);
       break;
+    case Token::kSHL:
+      ASSERT(result != right);
+      ASSERT(locs()->temp(0).reg() == RCX);
+      __ cmpq(right, Immediate(Smi::RawValue(Smi::kBits)));
+      __ j(ABOVE_EQUAL, slow_path->entry_label());
+
+      __ movq(RCX, right);
+      __ SmiUntag(RCX);
+      __ movq(result, left);
+      __ shlq(result, RCX);
+      __ movq(TMP, result);
+      __ sarq(TMP, RCX);
+      __ cmpq(TMP, result);
+      __ j(NOT_EQUAL, slow_path->entry_label());
+      break;
+    case Token::kSHR: {
+      Label shift_count_ok;
+      ASSERT(result != right);
+      ASSERT(locs()->temp(0).reg() == RCX);
+      __ cmpq(right, Immediate(0));
+      __ j(LESS, slow_path->entry_label());

[Florian Schneider, 2016/11/11 18:12:20]

Can you use unsigned compare "right <
(unsigned)Smi::RawValue(kMaxSmiShiftCount)" to save one comparison? (applies to
other platforms as well)

[rmacnak, 2016/11/11 21:29:02]

Yes. As discussed offline this means something like 1 >> 100 would go to the
slow path, but we expect this is rare.

+
+      __ movq(RCX, right);
+      __ SmiUntag(RCX);
+      __ cmpq(RCX, Immediate(0x3F));
+      __ j(LESS_EQUAL, &shift_count_ok, Assembler::kNearJump);
+      __ movq(RCX, Immediate(0x3F));
+      __ Bind(&shift_count_ok);
+      __ movq(result, left);
+      __ SmiUntag(result);
+      __ sarq(result, RCX);
+      __ SmiTag(result);
+      break;
+    }
     default:
       UNIMPLEMENTED();
   }
   __ Bind(slow_path->exit_label());
 }
 
 
 class CheckedSmiComparisonSlowPath : public SlowPathCode {
  public:
   CheckedSmiComparisonSlowPath(CheckedSmiComparisonInstr* instruction,
@@ skipping 3845 matching lines @@
   __ Drop(1);
   __ popq(result);
 }
 
 
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_X64