Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2487833002: Avoid calling out to JS during stack overflow (Closed)

Created:
4 years, 1 month ago by Dan Ehrenberg
Modified:
4 years, 1 month ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Avoid calling out to JS during stack overflow If an exception is thrown when there is a Promise being created, the Promise catch prediction code would call into a part implemented in JavaScript to see if the Promise has a catch handler. If it is not possible to call back into JS, e.g., due to a stack overflow, then this would lead to a crash. This patch "speculates" that, if it's impossible to call back into JavaScript, then the error is unhandled, avoding the issue. In a future patch, the catch prediction logic should be entirely written in C++, but this patch adds a minimal fix to be more friendly to backports. BUG=chromium:662935 R=jgruber Committed: https://crrev.com/5975c47a6a0da2ed1c8b6ea3d1d5867452e0ab29 Cr-Commit-Position: refs/heads/master@{#40851}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M src/isolate.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-662935.js View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Dan Ehrenberg
4 years, 1 month ago (2016-11-08 22:36:04 UTC) #2
jgruber
lgtm, nice!
4 years, 1 month ago (2016-11-09 07:50:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487833002/1
4 years, 1 month ago (2016-11-09 07:50:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 07:52:57 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:26:58 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5975c47a6a0da2ed1c8b6ea3d1d5867452e0ab29
Cr-Commit-Position: refs/heads/master@{#40851}

Powered by Google App Engine
This is Rietveld 408576698