Build chromium_gpu_debug_builder target on debug bots.

scripts/slave/recipes/gpu.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This recipe is intended to control all of the GPU related bots:
 #   chromium.gpu
 #   chromium.gpu.fyi
 #   The GPU bots on the chromium.webkit waterfall
 #   The GPU bots on the tryserver.chromium waterfall
 
@@ skipping 13 matching lines @@
   'gl_tests'
 ]
 
 def GenSteps(api):
   # These values may be replaced by external configuration later
   dashboard_upload_url = 'https://chromeperf.appspot.com'
   generated_dir = api.path.slave_build('content_gpu_data', 'generated')
   reference_dir = api.path.slave_build('content_gpu_data', 'reference')
   gsutil = api.path.build('scripts', 'slave', 'gsutil', wrapper=True)
 
+  is_release_build = api.properties.get('build_config', 'Release') == 'Release'
+
   api.chromium.set_config('chromium')
   api.gclient.apply_config('chrome_internal')
 
   # Don't skip the frame_rate data, as it's needed for the frame rate tests.
   # Per iannucci@, it can be relied upon that solutions[1] is src-internal.
   # Consider adding a 'gpu' module so that this can be managed in a
   # 'gpu' config.
   del api.gclient.c.solutions[1].custom_deps[
     'src/chrome/test/data/perf/frame_rate/private']
 
   api.chromium.c.gyp_env.GYP_DEFINES['internal_gles2_conform_tests'] = 1
 
   # If you want to stub out the checkout/runhooks/compile steps,
   # uncomment this line and then comment out the associated block of
   # yield statements below.
   # api.path.add_checkout(api.path.slave_build('src'))
 
   yield api.gclient.checkout()
   # If being run as a try server, apply the CL.
   if 'rietveld' in api.properties:
     yield api.rietveld.apply_issue()
   yield api.chromium.runhooks()
-  yield api.chromium.compile(targets=['chromium_gpu_builder'])
+  # Since performance tests aren't run on the debug builders, it isn't
+  # necessary to build all of the targets there.
+  if is_release_build:
+    yield api.chromium.compile(targets=['chromium_gpu_builder'])
+  else:
+    yield api.chromium.compile(targets=['chromium_gpu_debug_builder'])

[iannucci, 2013/09/26 23:22:30]

What about:

tag = '' if is_release_build else 'debug_'
yield api.chromium.compile(targets=['chromium_gpu_%sbuilder' % tag])

[Ken Russell (switch to Gerrit), 2013/09/26 23:52:41]

Thanks, that is simpler. Done.

 
   # TODO(kbr): currently some properties are passed to runtest.py via
   # factory_properties in the master.cfg: generate_gtest_json,
   # show_perf_results, test_results_server, and perf_id. runtest.py
   # should be modified to take these arguments on the command line,
   # and the setting of these properties should happen in this recipe
   # instead.
 
   # Note: --no-xvfb is the default.
   for test in SIMPLE_TESTS_TO_RUN:
@@ skipping 22 matching lines @@
           '%s_%s' % (api.properties['revision'], api.properties['buildername']),
           '--generated-dir', generated_dir,
           '--gpu-reference-dir', reference_dir,
           '--gsutil', gsutil]
   yield api.python('archive_test_results',
       api.path.build('scripts', 'slave', 'chromium', \
                      'archive_gpu_pixel_test_results.py'),
       args, always_run=True)
 
   # Only run the performance tests on Release builds.
-  if api.properties.get('build_config', 'Release') == 'Release':
+  if is_release_build:
     # Former gpu_frame_rate_test step
     args = ['--enable-gpu',
             '--gtest_filter=FrameRate*Test*']
     yield api.chromium.runtests('performance_ui_tests',
                                 args,
                                 name='gpu_frame_rate_test',
                                 annotate='framerate',
                                 results_url=dashboard_upload_url,
                                 perf_dashboard_id='gpu_frame_rate',
                                 test_type='gpu_frame_rate_test')
@@ skipping 35 matching lines @@
         api.properties.scheduled(build_config=build_config) +
         api.platform.name(plat)
       )
 
       # Try server configuration
       yield (
         api.test('%s_tryserver' % base_name) +
         api.properties.tryserver(build_config=build_config) +
         api.platform.name(plat)
       )