Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2487783003: gpu: Directly cast ClientBuffer to gfx::GpuMemoryBuffer (Closed)

Created:
4 years, 1 month ago by sadrul
Modified:
4 years, 1 month ago
Reviewers:
Khushal, reveman, sky, piman
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Directly cast ClientBuffer to gfx::GpuMemoryBuffer Directly cast ClientBuffer to gfx::GpuMemoryBuffer instead of going through GpuMemoryBufferManager::GpuMemoryBufferFromClientBuffer(). BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=khushalsagar@chromium.org for trivial change in //blimp Committed: https://crrev.com/849cb9e4fc81fe1d7249e474f4f9f61b568da052 Cr-Commit-Position: refs/heads/master@{#430958}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -72 lines) Patch
M blimp/client/support/compositor/blimp_gpu_memory_buffer_manager.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M blimp/client/support/compositor/blimp_gpu_memory_buffer_manager.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M cc/test/test_gpu_memory_buffer_manager.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M cc/test/test_gpu_memory_buffer_manager.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/gpu/browser_gpu_memory_buffer_manager.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/gpu/browser_gpu_memory_buffer_manager.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M content/child/child_gpu_memory_buffer_manager.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/child/child_gpu_memory_buffer_manager.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M gpu/command_buffer/client/gpu_memory_buffer_manager.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/client/command_buffer_proxy_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/client/gpu_memory_buffer_impl.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/ipc/client/gpu_memory_buffer_impl.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M services/ui/public/cpp/mojo_gpu_memory_buffer_manager.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M services/ui/public/cpp/mojo_gpu_memory_buffer_manager.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M services/ui/ws/mus_gpu_memory_buffer_manager.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M services/ui/ws/mus_gpu_memory_buffer_manager.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M ui/aura/mus/mojo_gpu_memory_buffer_manager.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ui/aura/mus/mojo_gpu_memory_buffer_manager.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 24 (16 generated)
sadrul
I haven't looked back in history to see if some implementations of GpuMemoryBufferFromClientBuffer() used to ...
4 years, 1 month ago (2016-11-09 04:26:36 UTC) #8
reveman
lgtm
4 years, 1 month ago (2016-11-09 07:53:24 UTC) #12
sadrul
+khushalsagar@ for blimp/ owner +piman@ for content/ and gpu/ owner +sky@ for services/ui
4 years, 1 month ago (2016-11-09 12:39:21 UTC) #14
sky
LGTM
4 years, 1 month ago (2016-11-09 16:26:01 UTC) #15
piman
lgtm
4 years, 1 month ago (2016-11-09 16:37:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487783003/20001
4 years, 1 month ago (2016-11-09 17:15:33 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-09 17:20:11 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 17:26:35 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/849cb9e4fc81fe1d7249e474f4f9f61b568da052
Cr-Commit-Position: refs/heads/master@{#430958}

Powered by Google App Engine
This is Rietveld 408576698