chrome/app/chrome_main_delegate.cc - Issue 2487783002: Make Crashpad use the user data dir, rather than always default location

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/chrome_main_delegate.cc

Issue 2487783002: Make Crashpad use the user data dir, rather than always default location (Closed)

Patch Set: . Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/app/chrome_main_delegate.cc

diff --git a/chrome/app/chrome_main_delegate.cc b/chrome/app/chrome_main_delegate.cc

index b33dec417a1fe9ab77c86e7868ff781748e5e2e8..521b8f5f48aa7e171bffaf216ec4b9a9060f5a68 100644

--- a/chrome/app/chrome_main_delegate.cc

+++ b/chrome/app/chrome_main_delegate.cc

@@ -359,6 +359,9 @@ struct MainFunction {

};

// Initializes the user data dir. Must be called before InitializeLocalState().

+// WARNING! It is important that this code match behavior with

+// GetUserDataDirectory() in chrome_elf. The two functions must be updated in

+// sync.

Mark Mentovai 2016/11/10 22:06:17 Can we add a test for equivalence? Or can we refac

scottmg 2016/11/15 23:23:14 Done.

void InitializeUserDataDir() {

base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();

base::FilePath user_data_dir =