Make Crashpad use the user data dir, rather than always default location

chrome/install_static/install_details.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_INSTALL_STATIC_INSTALL_DETAILS_H_
 #define CHROME_INSTALL_STATIC_INSTALL_DETAILS_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 29 matching lines @@
     // The brand-specific install mode for this install; see kInstallModes.
     const InstallConstants* mode;
 
     // The friendly name of this Chrome's channel, or an empty string if the
     // brand does not integrate with Google Update.
     const wchar_t* channel;
 
     // The string length of |channel| (not including the string terminator).
     size_t channel_length;
 
+    // The user data dir in use for this process.
+    const wchar_t* user_data_dir;
+
+    // The string length of |user_data_dir| (not including the string
+    // terminator).
+    size_t user_data_dir_length;
+
+    // The invalid user data dir in use for this process. This is set only when
+    // the user specified an unusable directory for the user data directory. It
+    // is saved off before the user data dir is replaced with a valid one, to be
+    // used later for an error dialog for the user.
+    const wchar_t* invalid_user_data_dir;
+
+    // The string length of |invalid_user_data_dir| (not including the string
+    // terminator).
+    size_t invalid_user_data_dir_length;
+
     // True if installed in C:\Program Files{, {x86)}; otherwise, false.
     bool system_level;
 
     // True if multi-install.
     bool multi_install;
   };
 
   InstallDetails(const InstallDetails&) = delete;
   InstallDetails(InstallDetails&&) = delete;
   InstallDetails& operator=(const InstallDetails&) = delete;
@@ skipping 24 matching lines @@
   // True if the mode supports multi-install.
   bool supports_multi_install() const {
     return payload_->mode->supports_multi_install;
   }
 
   // The install's update channel, or an empty string if the brand does not
   // integrate with Google Update.
   std::wstring channel() const {
     return std::wstring(payload_->channel, payload_->channel_length);
   }
+  std::wstring user_data_dir() const {
+    return std::wstring(payload_->user_data_dir,
+                        payload_->user_data_dir_length);
+  }
+  std::wstring invalid_user_data_dir() const {
+    if (!payload_->invalid_user_data_dir)
+      return std::wstring();
+    return std::wstring(payload_->invalid_user_data_dir,
+                        payload_->invalid_user_data_dir_length);
+  }
   bool system_level() const { return payload_->system_level; }
   bool multi_install() const { return payload_->multi_install; }
 
   // Returns the path to the installation's ClientState registry key. Returns
   // the path for the binaries if |binaries| and Chrome is
   // multi-install. Otherwise, returns the path for Chrome itself. This registry
   // key is used to hold various installation-related values, including an
   // indication of consent for usage stats.
   std::wstring GetClientStateKeyPath(bool binaries) const;
 
@@ skipping 44 matching lines @@
   PrimaryInstallDetails(const PrimaryInstallDetails&) = delete;
   PrimaryInstallDetails(PrimaryInstallDetails&&) = delete;
   PrimaryInstallDetails& operator=(const PrimaryInstallDetails&) = delete;
 
   void set_mode(const InstallConstants* mode) { payload_.mode = mode; }
   void set_channel(const std::wstring& channel) {
     channel_ = channel;
     payload_.channel = channel_.c_str();
     payload_.channel_length = channel_.size();
   }
+  void set_user_data_dir(const std::wstring& user_data_dir) {
+    user_data_dir_ = user_data_dir;
+    payload_.user_data_dir = user_data_dir_.c_str();
+    payload_.user_data_dir_length = user_data_dir_.size();
+  }
+  void set_invalid_user_data_dir(const std::wstring& invalid_user_data_dir) {
+    invalid_user_data_dir_ = invalid_user_data_dir;
+    payload_.invalid_user_data_dir = invalid_user_data_dir_.c_str();
+    payload_.invalid_user_data_dir_length = invalid_user_data_dir_.size();
+  }
   void set_system_level(bool system_level) {
     payload_.system_level = system_level;
   }
   void set_multi_install(bool multi_install) {
     payload_.multi_install = multi_install;
   }
 
+  static PrimaryInstallDetails* GetMutable();

[scottmg, 2016/11/18 20:48:27]

I assume you will dislike this solution, but I didn't think of a much better
one.

The derivation of the user data dir needs to be able to call
GetDefaultUserDataDirectory(), which needs AppendChromeInstallSubDirectory(),
which requires an set up InstallDetails.

Because of the create-and-move-into-place-as-immutable setup, I can't directly
create the user data dir ahead of time, nor install it later after the rest of
the InstallDetails have been set up. Maybe you have a better suggestion on how
to set this up?

+
  private:
   std::wstring channel_;
+  std::wstring user_data_dir_;
+  std::wstring invalid_user_data_dir_;
   Payload payload_ = Payload();
 };
 
 }  // namespace install_static
 
 #endif  // CHROME_INSTALL_STATIC_INSTALL_DETAILS_H_