Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Side by Side Diff: chrome/BUILD.gn

Issue 2487763002: [Mac/GN] Re-do framework packaging to fix framework versioning. (Closed)
Patch Set: address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/mac/rules.gni ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/locales.gni") 9 import("//build/config/locales.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 438 matching lines...) Expand 10 before | Expand all | Expand 10 after
449 "app/firstRun", 449 "app/firstRun",
450 ] 450 ]
451 outputs = [ 451 outputs = [
452 "$root_out_dir/First Run", 452 "$root_out_dir/First Run",
453 ] 453 ]
454 } 454 }
455 } else if (is_mac) { 455 } else if (is_mac) {
456 chrome_helper_name = chrome_product_full_name + " Helper" 456 chrome_helper_name = chrome_product_full_name + " Helper"
457 chrome_framework_name = chrome_product_full_name + " Framework" 457 chrome_framework_name = chrome_product_full_name + " Framework"
458 458
459 if (enable_xpc_notifications) {
460 chrome_framework_version = "A"
461 }
462
459 group("chrome") { 463 group("chrome") {
460 deps = [ 464 deps = [
461 ":chrome_app", 465 ":chrome_app",
462 ] 466 ]
463 467
464 data_deps = [ 468 data_deps = [
465 ":chrome_app", 469 ":chrome_app",
466 ] 470 ]
467 471
468 if (debug_devtools) { 472 if (debug_devtools) {
(...skipping 526 matching lines...) Expand 10 before | Expand all | Expand 10 after
995 if (enable_package_mash_services) { 999 if (enable_package_mash_services) {
996 deps += [ "//chrome/app/mash" ] 1000 deps += [ "//chrome/app/mash" ]
997 } 1001 }
998 1002
999 configs += [ "//build/config/compiler:wexit_time_destructors" ] 1003 configs += [ "//build/config/compiler:wexit_time_destructors" ]
1000 } 1004 }
1001 1005
1002 mac_framework_bundle("chrome_framework") { 1006 mac_framework_bundle("chrome_framework") {
1003 output_name = chrome_framework_name 1007 output_name = chrome_framework_name
1004 1008
1005 if (enable_xpc_notifications) { 1009 if (defined(chrome_framework_version)) {
1006 framework_version = "A" 1010 framework_version = chrome_framework_version
1011 framework_contents = [
1012 "Helpers",
1013 "Resources",
1014 ]
1015
1016 if (enable_xpc_notifications) {
1017 framework_contents += [ "XPCServices" ]
1018 }
1007 } 1019 }
1008 1020
1009 configs += [ "//build/config/compiler:wexit_time_destructors" ] 1021 configs += [ "//build/config/compiler:wexit_time_destructors" ]
1010 1022
1011 info_plist_target = ":chrome_framework_plist" 1023 info_plist_target = ":chrome_framework_plist"
1012 extra_substitutions = [ 1024 extra_substitutions = [
1013 "CHROMIUM_BUNDLE_ID=$chrome_mac_bundle_id", 1025 "CHROMIUM_BUNDLE_ID=$chrome_mac_bundle_id",
1014 "CHROMIUM_SHORT_NAME=$chrome_product_short_name", 1026 "CHROMIUM_SHORT_NAME=$chrome_product_short_name",
1015 ] 1027 ]
1016 1028
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
1069 args = [ 1081 args = [
1070 "--stamp", 1082 "--stamp",
1071 rebase_path(stamp_file, root_out_dir), 1083 rebase_path(stamp_file, root_out_dir),
1072 ] 1084 ]
1073 if (!use_system_xcode) { 1085 if (!use_system_xcode) {
1074 args += [ 1086 args += [
1075 "--developer_dir", 1087 "--developer_dir",
1076 hermetic_xcode_path, 1088 hermetic_xcode_path,
1077 ] 1089 ]
1078 } 1090 }
1091
1092 _framework_path = "$root_out_dir/$chrome_framework_name.framework/"
1093 if (defined(chrome_framework_version)) {
1094 _framework_path +=
1095 "Versions/$chrome_framework_version/$chrome_framework_name"
1096 } else {
1097 _framework_path += "$chrome_framework_name"
1098 }
1079 args += [ 1099 args += [
1080 "_ChromeMain", 1100 "_ChromeMain",
1081 rebase_path( 1101 rebase_path(_framework_path, root_out_dir),
1082 "$root_out_dir/$chrome_framework_name.framework/$chrome_framework_na me",
1083 root_out_dir),
1084 ] 1102 ]
1085 outputs = [ 1103 outputs = [
1086 stamp_file, 1104 stamp_file,
1087 ] 1105 ]
1088 public_deps = [ 1106 public_deps = [
1089 ":chrome_framework", 1107 ":chrome_framework",
1090 ] 1108 ]
1091 } 1109 }
1092 } else { 1110 } else {
1093 group("verify_chrome_framework_order") { 1111 group("verify_chrome_framework_order") {
(...skipping 479 matching lines...) Expand 10 before | Expand all | Expand 10 after
1573 "//chrome/app/theme/$branding_path_component/product_logo_48.png", 1591 "//chrome/app/theme/$branding_path_component/product_logo_48.png",
1574 "//chrome/tools/build/linux/chrome-wrapper", 1592 "//chrome/tools/build/linux/chrome-wrapper",
1575 "//third_party/xdg-utils/scripts/xdg-mime", 1593 "//third_party/xdg-utils/scripts/xdg-mime",
1576 "//third_party/xdg-utils/scripts/xdg-settings", 1594 "//third_party/xdg-utils/scripts/xdg-settings",
1577 ] 1595 ]
1578 outputs = [ 1596 outputs = [
1579 "$root_out_dir/{{source_file_part}}", 1597 "$root_out_dir/{{source_file_part}}",
1580 ] 1598 ]
1581 } 1599 }
1582 } 1600 }
OLDNEW
« no previous file with comments | « build/config/mac/rules.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698