Issue 248773002: aura: A couple of API cleanups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 248773002: aura: A couple of API cleanups. (Closed)

Created:
6 years, 8 months ago by sadrul

Modified:
6 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews, tdanderson+views_chromium.org, ben+aura_chromium.org, tfarina, kalyank, ben+views_chromium.org, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

aura: A couple of API cleanups. * Make Window::SetTransform() non-virtual. * Remove Window::SetEventFilter() (and use AddPreTargetHandler() instead). BUG=none R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265755

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+191 lines, -196 lines)			Patch
M	ash/first_run/first_run_helper_unittest.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	ash/root_window_controller_unittest.cc	View	1	4 chunks	+11 lines, -9 lines	0 comments	Download
M	ui/aura/window.h	View		3 chunks	+1 line, -8 lines	0 comments	Download
M	ui/aura/window.cc	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download
M	ui/aura/window_event_dispatcher_unittest.cc	View	1	43 chunks	+157 lines, -149 lines	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_native_widget_aura.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_native_widget_aura.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	ui/wm/core/input_method_event_filter_unittest.cc	View		2 chunks	+12 lines, -10 lines	0 comments	Download
M	ui/wm/test/wm_test_helper.h	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	ui/wm/test/wm_test_helper.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

sadrul

6 years, 8 months ago (2014-04-23 22:19:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r265755 (presubmit successful).