Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 2487713002: Resolves layering violation in SynchronousCompositorHost creation (Closed)
Patch Set: fixing tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index 78c0d2271379a3629f84f3621665b921121d1daf..8dbaba69b002bed4902deb18b159e0c3a7693021 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -435,7 +435,8 @@ void RenderWidgetHostViewAndroid::OnContextLost() {
RenderWidgetHostViewAndroid::RenderWidgetHostViewAndroid(
RenderWidgetHostImpl* widget_host,
- ContentViewCoreImpl* content_view_core)
+ ContentViewCoreImpl* content_view_core,
+ SynchronousCompositorClient* compositor_client)
: host_(widget_host),
outstanding_vsync_requests_(0),
is_showing_(!widget_host->is_hidden()),
@@ -450,6 +451,7 @@ RenderWidgetHostViewAndroid::RenderWidgetHostViewAndroid(
this),
stylus_text_selector_(this),
using_browser_compositor_(CompositorImpl::IsInitialized()),
+ synchronous_compositor_client_(compositor_client),
frame_evictor_(new DelegatedFrameEvictor(this)),
locks_on_frame_count_(0),
observing_root_window_(false),
@@ -1790,8 +1792,7 @@ void RenderWidgetHostViewAndroid::SetContentViewCore(
}
if (!sync_compositor_) {
- sync_compositor_ = SynchronousCompositorHost::Create(
- this, content_view_core_->GetWebContents());
+ sync_compositor_ = SynchronousCompositorHost::Create(this);
}
}

Powered by Google App Engine
This is Rietveld 408576698