Remove legacy policy cache support on chromeos

Remove legacy policy cache support on chromeos

Remove obsolete loading of legacy policy cache files from the chrome
profile (created before session_manager was used to store policy).
Also remove unit tests which were testing the migration path.

BUG=655956
TEST=ran all components_unittests and unit_tests

Committed: https://crrev.com/21108b94206bdb524c67b3d4b765b6965cecc4bd
Cr-Commit-Position: refs/heads/master@{#433818}

[pmarko, 2016-11-08 15:14:11]

The CQ bit was checked by pmarko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 15:14:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pmarko, 2016-11-08 15:16:07]

Description was changed from

==========
Remove legacy policy cache support on chromeos

Remove obsolete loading of legacy policy cache files from the chrome
profile (created before session_manager was used to store policy).
Also remove unit tests which were testing the migration path.

BUG=655956
TEST=ran all components_unittests and unit_tests
==========

to

==========
Remove legacy policy cache support on chromeos

Remove obsolete loading of legacy policy cache files from the chrome
profile (created before session_manager was used to store policy).
Also remove unit tests which were testing the migration path.

BUG=655956
TEST=ran all components_unittests and unit_tests
==========

[pmarko, 2016-11-08 15:16:07]

pmarko@chromium.org changed reviewers:
+ atwilson@chromium.org, pastarmovj@chromium.org, tnagel@chromium.org

[commit-bot: I haz the power, 2016-11-08 15:38:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 15:38:21]

Dry run: This issue passed the CQ dry run.

[pmarko, 2016-11-08 15:39:30]

Thank you for reviewing!

[Andrew T Wilson (Slow), 2016-11-08 15:50:40]

LGTM with a couple of nits.

https://codereview.chromium.org/2487703002/diff/1/chrome/browser/chromeos/pol...
File
chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc
(right):

https://codereview.chromium.org/2487703002/diff/1/chrome/browser/chromeos/pol...
chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc:47:
// stored, see the follow constants for details.
nit: follow->following

https://codereview.chromium.org/2487703002/diff/1/chrome/browser/chromeos/pol...
File chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc (right):

https://codereview.chromium.org/2487703002/diff/1/chrome/browser/chromeos/pol...
chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc:359: //
verification key.
Actually, the "legacy policy" described in this comment is different from the
legacy policy you're removing. So restore the old comment language.

[pmarko, 2016-11-14 11:27:07]

pmarko@chromium.org changed reviewers:
- atwilson@chromium.org

[pmarko, 2016-11-14 11:27:07]

Hi Julian, Thiemo,

just a quick ping - would you like to take a look at the change?

Thanks!

[pastarmovj, 2016-11-16 13:44:54]

On 2016/11/14 11:27:07, pmarko wrote:
> Hi Julian, Thiemo,
> 
> just a quick ping - would you like to take a look at the change?
> 
> Thanks!

I don't mind this change and you already have owners approval. :)

[pmarko, 2016-11-21 13:10:09]

The CQ bit was checked by pmarko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 13:10:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 15:37:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 15:37:26]

Dry run: This issue passed the CQ dry run.

[pmarko, 2016-11-22 08:55:54]

The CQ bit was checked by pmarko@chromium.org

[pmarko, 2016-11-22 08:55:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
atwilson@chromium.org
Link to the patchset: https://codereview.chromium.org/2487703002/#ps40001
(title: "Fixed multiline comment added by accident")

[commit-bot: I haz the power, 2016-11-22 08:56:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 08:58:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479804954814460,
"parent_rev": "048708c09f3ff5064f1429c41a64d4439b9a25be", "commit_rev":
"a0cb8bad09fbd84b953809a62a251609e5e23ff1"}

[commit-bot: I haz the power, 2016-11-22 08:59:22]

Description was changed from

==========
Remove legacy policy cache support on chromeos

Remove obsolete loading of legacy policy cache files from the chrome
profile (created before session_manager was used to store policy).
Also remove unit tests which were testing the migration path.

BUG=655956
TEST=ran all components_unittests and unit_tests
==========

to

==========
Remove legacy policy cache support on chromeos

Remove obsolete loading of legacy policy cache files from the chrome
profile (created before session_manager was used to store policy).
Also remove unit tests which were testing the migration path.

BUG=655956
TEST=ran all components_unittests and unit_tests
==========

[commit-bot: I haz the power, 2016-11-22 08:59:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-22 09:09:28]

Description was changed from

==========
Remove legacy policy cache support on chromeos

Remove obsolete loading of legacy policy cache files from the chrome
profile (created before session_manager was used to store policy).
Also remove unit tests which were testing the migration path.

BUG=655956
TEST=ran all components_unittests and unit_tests
==========

to

==========
Remove legacy policy cache support on chromeos

Remove obsolete loading of legacy policy cache files from the chrome
profile (created before session_manager was used to store policy).
Also remove unit tests which were testing the migration path.

BUG=655956
TEST=ran all components_unittests and unit_tests

Committed: https://crrev.com/21108b94206bdb524c67b3d4b765b6965cecc4bd
Cr-Commit-Position: refs/heads/master@{#433818}
==========

[commit-bot: I haz the power, 2016-11-22 09:09:29]

Patchset 3 (id:??) landed as
https://crrev.com/21108b94206bdb524c67b3d4b765b6965cecc4bd
Cr-Commit-Position: refs/heads/master@{#433818}