Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: Source/modules/webaudio/OfflineAudioContext.cpp

Issue 24877002: Add more informative messages for DOM exceptions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012, Google Inc. All rights reserved. 2 * Copyright (C) 2012, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 10 matching lines...) Expand all
21 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS 21 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
22 * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 22 * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
23 */ 23 */
24 24
25 #include "config.h" 25 #include "config.h"
26 26
27 #if ENABLE(WEB_AUDIO) 27 #if ENABLE(WEB_AUDIO)
28 28
29 #include "modules/webaudio/OfflineAudioContext.h" 29 #include "modules/webaudio/OfflineAudioContext.h"
30 30
31 #include "bindings/v8/ExceptionMessages.h"
31 #include "bindings/v8/ExceptionState.h" 32 #include "bindings/v8/ExceptionState.h"
32 #include "core/dom/Document.h" 33 #include "core/dom/Document.h"
33 #include "core/dom/ExceptionCode.h" 34 #include "core/dom/ExceptionCode.h"
34 #include "core/dom/ScriptExecutionContext.h" 35 #include "core/dom/ScriptExecutionContext.h"
35 36
36 namespace WebCore { 37 namespace WebCore {
37 38
38 PassRefPtr<OfflineAudioContext> OfflineAudioContext::create(ScriptExecutionConte xt* context, unsigned numberOfChannels, size_t numberOfFrames, float sampleRate, ExceptionState& es) 39 PassRefPtr<OfflineAudioContext> OfflineAudioContext::create(ScriptExecutionConte xt* context, unsigned numberOfChannels, size_t numberOfFrames, float sampleRate, ExceptionState& es)
39 { 40 {
40 // FIXME: add support for workers. 41 // FIXME: add support for workers.
41 if (!context || !context->isDocument()) { 42 if (!context || !context->isDocument()) {
42 es.throwUninformativeAndGenericDOMException(NotSupportedError); 43 es.throwDOMException(
44 NotSupportedError,
45 ExceptionMessages::failedToConstruct("OfflineAudioContext"));
43 return 0; 46 return 0;
44 } 47 }
45 48
46 Document* document = toDocument(context); 49 Document* document = toDocument(context);
47 50
48 if (numberOfChannels > 10 || !isSampleRateRangeGood(sampleRate)) { 51 if (numberOfChannels > 10 || !isSampleRateRangeGood(sampleRate)) {
49 es.throwUninformativeAndGenericDOMException(SyntaxError); 52 es.throwDOMException(
53 SyntaxError,
54 ExceptionMessages::failedToConstruct(
55 "OfflineAudioContext",
56 "invalid number of channels or sample rate"));
Mike West 2013/09/27 06:44:39 Same as above.
50 return 0; 57 return 0;
51 } 58 }
52 59
53 RefPtr<OfflineAudioContext> audioContext(adoptRef(new OfflineAudioContext(do cument, numberOfChannels, numberOfFrames, sampleRate))); 60 RefPtr<OfflineAudioContext> audioContext(adoptRef(new OfflineAudioContext(do cument, numberOfChannels, numberOfFrames, sampleRate)));
54 audioContext->suspendIfNeeded(); 61 audioContext->suspendIfNeeded();
55 return audioContext.release(); 62 return audioContext.release();
56 } 63 }
57 64
58 OfflineAudioContext::OfflineAudioContext(Document* document, unsigned numberOfCh annels, size_t numberOfFrames, float sampleRate) 65 OfflineAudioContext::OfflineAudioContext(Document* document, unsigned numberOfCh annels, size_t numberOfFrames, float sampleRate)
59 : AudioContext(document, numberOfChannels, numberOfFrames, sampleRate) 66 : AudioContext(document, numberOfChannels, numberOfFrames, sampleRate)
60 { 67 {
61 ScriptWrappable::init(this); 68 ScriptWrappable::init(this);
62 } 69 }
63 70
64 OfflineAudioContext::~OfflineAudioContext() 71 OfflineAudioContext::~OfflineAudioContext()
65 { 72 {
66 } 73 }
67 74
68 } // namespace WebCore 75 } // namespace WebCore
69 76
70 #endif // ENABLE(WEB_AUDIO) 77 #endif // ENABLE(WEB_AUDIO)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698