Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildProcessCreationParams.java

Issue 2487673006: Fix bug: turns on BIND_EXTERNAL_SERVICE flag on Android N crashes WebAPK. (Closed)
Patch Set: Add a TODO. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ChildProcessCreationParams.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessCreationParams.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessCreationParams.java
index 14858481abd4182dd4ff15f164ea36893ebf0396..a8fd972bb4d0cf249b8c33f0fdb5934c514ba76b 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessCreationParams.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessCreationParams.java
@@ -16,7 +16,7 @@ import org.chromium.base.library_loader.LibraryProcessType;
*/
public class ChildProcessCreationParams {
private final String mPackageName;
- private final int mExtraBindFlags;
+ private final boolean mIsExternalService;
private final int mLibraryProcessType;
private static final String EXTRA_LIBRARY_PROCESS_TYPE =
"org.chromium.content.common.child_service_params.library_process_type";
@@ -31,40 +31,30 @@ public class ChildProcessCreationParams {
return sChildProcessCreationParams;
}
- public ChildProcessCreationParams(String packageName, int extraBindFlags,
+ public ChildProcessCreationParams(String packageName, boolean isExternalService,
int libraryProcessType) {
mPackageName = packageName;
- mExtraBindFlags = extraBindFlags;
+ mIsExternalService = isExternalService;
mLibraryProcessType = libraryProcessType;
}
public ChildProcessCreationParams copy() {
- return new ChildProcessCreationParams(mPackageName, mExtraBindFlags, mLibraryProcessType);
+ return new ChildProcessCreationParams(mPackageName, mIsExternalService,
+ mLibraryProcessType);
}
public String getPackageName() {
return mPackageName;
}
- public int getExtraBindFlags() {
- return mExtraBindFlags;
+ public boolean getIsExternalService() {
+ return mIsExternalService;
}
public int getLibraryProcessType() {
return mLibraryProcessType;
}
- /**
- * Adds required extra flags to the given child service binding flags and returns them.
- * Does not modify the state of the ChildProcessCreationParams instance.
- *
- * @param bindFlags Source bind flags to modify.
- * @return Bind flags with extra flags added.
- */
- public int addExtraBindFlags(int bindFlags) {
- return bindFlags | mExtraBindFlags;
- }
-
public void addIntentExtras(Intent intent) {
intent.putExtra(EXTRA_LIBRARY_PROCESS_TYPE, mLibraryProcessType);
}

Powered by Google App Engine
This is Rietveld 408576698