Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Side by Side Diff: test/fuzzer/wasm-code.cc

Issue 2487673004: [wasm] Fix -Wsign-compare warnings. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <stdint.h> 6 #include <stdint.h>
7 7
8 #include "include/v8.h" 8 #include "include/v8.h"
9 #include "src/isolate.h" 9 #include "src/isolate.h"
10 #include "src/objects.h" 10 #include "src/objects.h"
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 int32_t result_compiled; 84 int32_t result_compiled;
85 { 85 {
86 v8::internal::Handle<v8::internal::Object> arguments[] = { 86 v8::internal::Handle<v8::internal::Object> arguments[] = {
87 v8::internal::handle(v8::internal::Smi::FromInt(1), i_isolate), 87 v8::internal::handle(v8::internal::Smi::FromInt(1), i_isolate),
88 v8::internal::handle(v8::internal::Smi::FromInt(2), i_isolate), 88 v8::internal::handle(v8::internal::Smi::FromInt(2), i_isolate),
89 v8::internal::handle(v8::internal::Smi::FromInt(3), i_isolate)}; 89 v8::internal::handle(v8::internal::Smi::FromInt(3), i_isolate)};
90 result_compiled = testing::CallWasmFunctionForTesting( 90 result_compiled = testing::CallWasmFunctionForTesting(
91 i_isolate, instance, &compiler_thrower, "main", arraysize(arguments), 91 i_isolate, instance, &compiler_thrower, "main", arraysize(arguments),
92 arguments, v8::internal::wasm::ModuleOrigin::kWasmOrigin); 92 arguments, v8::internal::wasm::ModuleOrigin::kWasmOrigin);
93 } 93 }
94 if (result_interpreted == 0xdeadbeef) { 94 if (result_interpreted == bit_cast<int32_t>(0xdeadbeef)) {
95 CHECK(i_isolate->has_pending_exception()); 95 CHECK(i_isolate->has_pending_exception());
96 i_isolate->clear_pending_exception(); 96 i_isolate->clear_pending_exception();
97 } else { 97 } else {
98 // The WebAssembly spec allows the sign bit of NaN to be non-deterministic. 98 // The WebAssembly spec allows the sign bit of NaN to be non-deterministic.
99 // This sign bit may cause result_interpreted to be different than 99 // This sign bit may cause result_interpreted to be different than
100 // result_compiled. Therefore we do not check the equality of the results 100 // result_compiled. Therefore we do not check the equality of the results
101 // if the execution may have produced a NaN at some point. 101 // if the execution may have produced a NaN at some point.
102 if (!possible_nondeterminism && (result_interpreted != result_compiled)) { 102 if (!possible_nondeterminism && (result_interpreted != result_compiled)) {
103 V8_Fatal(__FILE__, __LINE__, "WasmCodeFuzzerHash=%x", 103 V8_Fatal(__FILE__, __LINE__, "WasmCodeFuzzerHash=%x",
104 v8::internal::StringHasher::HashSequentialString( 104 v8::internal::StringHasher::HashSequentialString(
105 data, static_cast<int>(size), WASM_CODE_FUZZER_HASH_SEED)); 105 data, static_cast<int>(size), WASM_CODE_FUZZER_HASH_SEED));
106 } 106 }
107 } 107 }
108 return 0; 108 return 0;
109 } 109 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698