Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: test/fuzzer/wasm-call.cc

Issue 2487673004: [wasm] Fix -Wsign-compare warnings. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <stdint.h> 6 #include <stdint.h>
7 7
8 #include "include/v8.h" 8 #include "include/v8.h"
9 #include "src/isolate.h" 9 #include "src/isolate.h"
10 #include "src/objects.h" 10 #include "src/objects.h"
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 CHECK(!instance.is_null()); 158 CHECK(!instance.is_null());
159 } else { 159 } else {
160 return 0; 160 return 0;
161 } 161 }
162 int32_t result_compiled; 162 int32_t result_compiled;
163 { 163 {
164 result_compiled = testing::CallWasmFunctionForTesting( 164 result_compiled = testing::CallWasmFunctionForTesting(
165 i_isolate, instance, &compiler_thrower, "main", argc, compiled_args, 165 i_isolate, instance, &compiler_thrower, "main", argc, compiled_args,
166 v8::internal::wasm::ModuleOrigin::kWasmOrigin); 166 v8::internal::wasm::ModuleOrigin::kWasmOrigin);
167 } 167 }
168 if (result_interpreted == 0xdeadbeef) { 168 if (result_interpreted == bit_cast<int32_t>(0xdeadbeef)) {
169 CHECK(i_isolate->has_pending_exception()); 169 CHECK(i_isolate->has_pending_exception());
170 i_isolate->clear_pending_exception(); 170 i_isolate->clear_pending_exception();
171 } else { 171 } else {
172 // The WebAssembly spec allows the sign bit of NaN to be non-deterministic. 172 // The WebAssembly spec allows the sign bit of NaN to be non-deterministic.
173 // This sign bit may cause result_interpreted to be different than 173 // This sign bit may cause result_interpreted to be different than
174 // result_compiled. Therefore we do not check the equality of the results 174 // result_compiled. Therefore we do not check the equality of the results
175 // if the execution may have produced a NaN at some point. 175 // if the execution may have produced a NaN at some point.
176 if (!possible_nondeterminism && (result_interpreted != result_compiled)) { 176 if (!possible_nondeterminism && (result_interpreted != result_compiled)) {
177 V8_Fatal(__FILE__, __LINE__, "WasmCodeFuzzerHash=%x", 177 V8_Fatal(__FILE__, __LINE__, "WasmCodeFuzzerHash=%x",
178 v8::internal::StringHasher::HashSequentialString( 178 v8::internal::StringHasher::HashSequentialString(
179 data, static_cast<int>(size), WASM_CODE_FUZZER_HASH_SEED)); 179 data, static_cast<int>(size), WASM_CODE_FUZZER_HASH_SEED));
180 } 180 }
181 } 181 }
182 return 0; 182 return 0;
183 } 183 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698