Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Unified Diff: chrome/browser/ui/webui/media_router/media_router_ui.cc

Issue 2487673003: [Media Router] Make per-hostname cast mode selections persist (Closed)
Patch Set: Address Jennifer's comments, rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/media_router/media_router_ui.cc
diff --git a/chrome/browser/ui/webui/media_router/media_router_ui.cc b/chrome/browser/ui/webui/media_router/media_router_ui.cc
index 3374fc27a4c5285c2972b246aa0fd5e50e5f571d..cec41cdc8115acd723a29281fa11ea5d90f652ad 100644
--- a/chrome/browser/ui/webui/media_router/media_router_ui.cc
+++ b/chrome/browser/ui/webui/media_router/media_router_ui.cc
@@ -36,8 +36,11 @@
#include "chrome/browser/ui/webui/media_router/media_router_localized_strings_provider.h"
#include "chrome/browser/ui/webui/media_router/media_router_resources_provider.h"
#include "chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h"
+#include "chrome/common/pref_names.h"
#include "chrome/common/url_constants.h"
#include "chrome/grit/generated_resources.h"
+#include "components/prefs/pref_service.h"
+#include "components/prefs/scoped_user_pref_update.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_ui.h"
#include "content/public/browser/web_ui_data_source.h"
@@ -507,6 +510,25 @@ void MediaRouterUI::SearchSinksAndCreateRoute(
weak_factory_.GetWeakPtr(), cast_mode));
}
+MediaCastMode MediaRouterUI::GetCastModeSelectionForCurrentHost() const {
+ const base::DictionaryValue* selections =
+ Profile::FromWebUI(web_ui())->GetPrefs()->GetDictionary(
+ prefs::kMediaRouterCastModeSelections);
+ int cast_mode = MediaCastMode::DEFAULT;
+ selections->GetInteger(GetInitiatorHostname(), &cast_mode);
+ return static_cast<MediaCastMode>(cast_mode);
imcheng 2016/11/14 19:32:27 DCHECK the value from pref that it is a valid cast
takumif 2016/11/16 01:34:27 Done.
+}
+
+void MediaRouterUI::RecordCastModeSelection(MediaCastMode cast_mode) {
+ // Desktop mirroring isn't domain-specific, so we don't record the selection.
+ if (cast_mode == MediaCastMode::DESKTOP_MIRROR)
+ return;
+
+ DictionaryPrefUpdate update(Profile::FromWebUI(web_ui())->GetPrefs(),
+ prefs::kMediaRouterCastModeSelections);
+ update->SetInteger(GetInitiatorHostname(), static_cast<int>(cast_mode));
+}
+
void MediaRouterUI::OnResultsUpdated(
const std::vector<MediaSinkWithCastModes>& sinks) {
sinks_ = sinks;
@@ -696,4 +718,8 @@ void MediaRouterUI::UpdateMaxDialogHeight(int height) {
handler_->UpdateMaxDialogHeight(height);
}
+std::string MediaRouterUI::GetInitiatorHostname() const {
+ return initiator_ ? initiator_->GetLastCommittedURL().HostNoBrackets() : "";
+}
+
} // namespace media_router

Powered by Google App Engine
This is Rietveld 408576698