[Media Router] Make per-hostname cast mode selections persist

chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h"
 
 #include <string>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 401 matching lines @@
   std::unique_ptr<base::ListValue> routes(RoutesToValue(
       media_router_ui_->routes(), media_router_ui_->joinable_route_ids(),
       media_router_ui_->current_cast_modes()));
   initial_data.Set("routes", routes.release());
 
   const std::set<MediaCastMode> cast_modes = media_router_ui_->cast_modes();
   std::unique_ptr<base::ListValue> cast_modes_list(CastModesToValue(
       cast_modes, media_router_ui_->GetPresentationRequestSourceName()));
   initial_data.Set("castModes", cast_modes_list.release());
 
+  MediaCastMode initial_cast_mode =

[imcheng, 2016/11/14 19:56:59]

What if |initial_cast_mode| is not in |cast_modes|?

[takumif, 2016/11/16 01:34:27]

Checking to make sure TAB_MIRROR is in |cast_modes| when overriding with tab
mirroring.

+      media_router_ui_->GetCastModeSelectionForCurrentHost();
+  if (initial_cast_mode != MediaCastMode::DEFAULT) {

[takumif, 2016/11/08 22:52:16]

Right now, GetCastModeSelectionForCurrentHost() returns MediaCastMode::DEFAULT
if user hasn't chosen anything, so we can't distinguish between sites where the
user has chosen DEFAULT and hasn't chosen anything. So in the case the user has
chosen DEFAULT we don't set the initial cast mode, but the webui defaults to
DEFAULT anyways.

I thought about making GetCastModeSelectionForCurrentHost() return an int
(instead of MediaCastMode) and make it return 0 to indicate the user hasn't
chosen anything, but that didn't seem as clean. apacible@, I wonder if the
current way is okay, or there's a better way to do this.

[apacible, 2016/11/11 22:40:23]

This looks fine.

[takumif, 2016/11/12 00:08:31]

Okay!

[imcheng, 2016/11/14 19:56:59]

Saw this comment after I posted my own comments. Note there is a slight
difference in behavior if we don't set initialCastMode = DEFAULT.
- if initialCastMode is not set, the dialog is in AUTO mode - which means we
will show sinks that are compatible with any one cast mode, and we will create
route using the best cast mode (DEFAULT > TAB_MIRROR > DESKTOP_MIRROR) when
selected.
- if set, the dialog will only show devices that can do DEFAULT mode.


The code here effectively means we are only setting initialCastMode for
TAB_MIRROR only, or not at all. Do we plan to support initialCastMode = DEFAULT?
(It doesn't look very useful to me, under the assumption that DEFAULT >
TAB_MIRROR). If not, would it suffice to just store a boolean instead of int as
the pref?

Finally, please document the logic here and any assumptions made regarding the
use of DEFAULT. 

[takumif, 2016/11/16 01:34:27]

Changing the pref to only keep track of hostnames set to TAB_MIRROR.

+    initial_data.Set(
+        "initialCastMode",
+        new base::FundamentalValue(static_cast<int>(initial_cast_mode)));
+  }
+
   web_ui()->CallJavascriptFunctionUnsafe(kSetInitialData, initial_data);
   media_router_ui_->UIInitialized();
 }
 
 void MediaRouterWebUIMessageHandler::OnCreateRoute(
     const base::ListValue* args) {
   DVLOG(1) << "OnCreateRoute";
   const base::DictionaryValue* args_dict = nullptr;
   std::string sink_id;
   int cast_mode_num = -1;
@@ skipping 259 matching lines @@
 void MediaRouterWebUIMessageHandler::OnReportSelectedCastMode(
     const base::ListValue* args) {
   DVLOG(1) << "OnReportSelectedCastMode";
   int cast_mode_type;
   if (!args->GetInteger(0, &cast_mode_type)) {
     DVLOG(1) << "Unable to extract args.";
     return;
   }
   UMA_HISTOGRAM_SPARSE_SLOWLY("MediaRouter.Ui.Navigate.SourceSelection",
                               cast_mode_type);
+  media_router_ui_->RecordCastModeSelection(
+      static_cast<MediaCastMode>(cast_mode_type));
 }
 
 void MediaRouterWebUIMessageHandler::OnReportSinkCount(
     const base::ListValue* args) {
   DVLOG(1) << "OnReportSinkCount";
   int sink_count;
   if (!args->GetInteger(0, &sink_count)) {
     DVLOG(1) << "Unable to extract args.";
     return;
   }
@@ skipping 169 matching lines @@
   }
 
   return value;
 }
 
 void MediaRouterWebUIMessageHandler::SetWebUIForTest(content::WebUI* web_ui) {
   set_web_ui(web_ui);
 }
 
 }  // namespace media_router