Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2487653002: Moved applyRuleSetChanges functions to StyleEngine. (Closed)

Created:
4 years, 1 month ago by rune
Modified:
4 years, 1 month ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved applyRuleSetChanges functions to StyleEngine. A lot of the side effects were calls to StyleEngine, so moved the method there instead. Also fixed the TODO for adding the call to make CSSGlobalRuleSet dirty. BUG=567021 Committed: https://crrev.com/c2e0d164125e177ce62925ac66f9fcdb4f457e1c Cr-Commit-Position: refs/heads/master@{#431227}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -110 lines) Patch
M third_party/WebKit/Source/core/css/ActiveStyleSheets.h View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/ActiveStyleSheets.cpp View 1 chunk +0 lines, -90 lines 0 comments Download
M third_party/WebKit/Source/core/css/ActiveStyleSheetsTest.cpp View 7 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.h View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 1 chunk +90 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
rune
ptal
4 years, 1 month ago (2016-11-08 14:02:21 UTC) #4
sashab
lgtm https://codereview.chromium.org/2487653002/diff/1/third_party/WebKit/Source/core/dom/StyleEngine.cpp File third_party/WebKit/Source/core/dom/StyleEngine.cpp (right): https://codereview.chromium.org/2487653002/diff/1/third_party/WebKit/Source/core/dom/StyleEngine.cpp#newcode1067 third_party/WebKit/Source/core/dom/StyleEngine.cpp:1067: m_globalRuleSet.markDirty(); Maybe add a comment explaining what this ...
4 years, 1 month ago (2016-11-09 23:45:29 UTC) #7
rune
https://codereview.chromium.org/2487653002/diff/1/third_party/WebKit/Source/core/dom/StyleEngine.cpp File third_party/WebKit/Source/core/dom/StyleEngine.cpp (right): https://codereview.chromium.org/2487653002/diff/1/third_party/WebKit/Source/core/dom/StyleEngine.cpp#newcode1067 third_party/WebKit/Source/core/dom/StyleEngine.cpp:1067: m_globalRuleSet.markDirty(); On 2016/11/09 23:45:29, sashab wrote: > Maybe add ...
4 years, 1 month ago (2016-11-10 08:10:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487653002/20001
4 years, 1 month ago (2016-11-10 08:11:15 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-10 09:49:43 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 09:54:06 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c2e0d164125e177ce62925ac66f9fcdb4f457e1c
Cr-Commit-Position: refs/heads/master@{#431227}

Powered by Google App Engine
This is Rietveld 408576698