Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1204)

Issue 2487643002: Revert of Turn on hermetic toolchain for all corp machines. (Closed)

Created:
4 years, 1 month ago by sdefresne
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Turn on hermetic toolchain for all corp machines. (patchset #2 id:20001 of https://codereview.chromium.org/2445993004/ ) Reason for revert: This break developer workflow for Googlers (as build/mac/should_use_hermetic_xcode.py returns 1) as the hermetic build does not contains support for iOS SDK, thus "gn gen" fails with the following error: $ gn gen --args='target_os="ios"' out/default ERROR at //build/config/ios/ios_sdk.gni:98:21: Script returned non-zero exit code. _ios_sdk_result = exec_script(script_name, ios_sdk_info_args, "scope") ^---------- Current dir: /Users/sdefresne/Developer/chromium/src/out/default/ Command: python -- /Users/sdefresne/Developer/chromium/src/build/config/mac/sdk_info.py --developer_dir /Users/sdefresne/Developer/chromium/src/build/mac_files/Xcode.app iphonesimulator Returned 1. stderr: xcodebuild: error: SDK "iphonesimulator" cannot be located. xcodebuild: error: SDK "iphonesimulator" cannot be located. xcrun: error: unable to lookup item 'Path' in SDK 'iphonesimulator' The was not caught by the bots because they do not set FORCE_MAC_TOOLCHAIN and are not corporate machine. Original issue's description: > Turn on hermetic toolchain for all corp machines. > > BUG=659726 > > Committed: https://crrev.com/7778e931dabc1fa85d0b77321e3fdef166e0b6a0 > Cr-Commit-Position: refs/heads/master@{#430376} TBR=thakis@chromium.org,dpranke@chromium.org,brettw@chromium.org,justincohen@chromium.org,erikchen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=659726 Committed: https://crrev.com/e62f1a5d8886fc1086a180f4da94e0a3d1ca03dc Cr-Commit-Position: refs/heads/master@{#430553}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -68 lines) Patch
M .gn View 1 chunk +0 lines, -1 line 0 comments Download
D build/mac/should_use_hermetic_xcode.py View 1 chunk +0 lines, -26 lines 0 comments Download
M build/mac_toolchain.py View 3 chunks +25 lines, -39 lines 0 comments Download
M build/toolchain/toolchain.gni View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sdefresne
Created Revert of Turn on hermetic toolchain for all corp machines.
4 years, 1 month ago (2016-11-08 09:08:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487643002/1
4 years, 1 month ago (2016-11-08 09:09:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 09:11:17 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e62f1a5d8886fc1086a180f4da94e0a3d1ca03dc Cr-Commit-Position: refs/heads/master@{#430553}
4 years, 1 month ago (2016-11-08 09:21:51 UTC) #7
Dirk Pranke
4 years, 1 month ago (2016-11-08 18:34:06 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698