Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: components/search_engines/keyword_table_unittest.cc

Issue 2487633003: Change behaivor to decide whether a search engine should be shown in the default list (Closed)
Patch Set: Update based on Peter and Nicolas's comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/search_engines/keyword_table.cc ('k') | components/search_engines/template_url.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 #include <vector> 6 #include <vector>
7 7
8 #include "base/files/scoped_temp_dir.h" 8 #include "base/files/scoped_temp_dir.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 keyword.SetKeyword(ASCIIToUTF16("keyword")); 46 keyword.SetKeyword(ASCIIToUTF16("keyword"));
47 keyword.SetURL("http://url/"); 47 keyword.SetURL("http://url/");
48 keyword.suggestions_url = "url2"; 48 keyword.suggestions_url = "url2";
49 keyword.instant_url = "http://instant/"; 49 keyword.instant_url = "http://instant/";
50 keyword.image_url = "http://image-search-url/"; 50 keyword.image_url = "http://image-search-url/";
51 keyword.new_tab_url = "http://new-tab-url/"; 51 keyword.new_tab_url = "http://new-tab-url/";
52 keyword.search_url_post_params = "ie=utf-8,oe=utf-8"; 52 keyword.search_url_post_params = "ie=utf-8,oe=utf-8";
53 keyword.image_url_post_params = "name=1,value=2"; 53 keyword.image_url_post_params = "name=1,value=2";
54 keyword.favicon_url = GURL("http://favicon.url/"); 54 keyword.favicon_url = GURL("http://favicon.url/");
55 keyword.originating_url = GURL("http://google.com/"); 55 keyword.originating_url = GURL("http://google.com/");
56 keyword.show_in_default_list = true;
57 keyword.safe_for_autoreplace = true; 56 keyword.safe_for_autoreplace = true;
58 keyword.input_encodings.push_back("UTF-8"); 57 keyword.input_encodings.push_back("UTF-8");
59 keyword.input_encodings.push_back("UTF-16"); 58 keyword.input_encodings.push_back("UTF-16");
60 keyword.id = 1; 59 keyword.id = 1;
61 keyword.date_created = base::Time::UnixEpoch(); 60 keyword.date_created = base::Time::UnixEpoch();
62 keyword.last_modified = base::Time::UnixEpoch(); 61 keyword.last_modified = base::Time::UnixEpoch();
63 keyword.created_by_policy = true; 62 keyword.created_by_policy = true;
64 keyword.usage_count = 32; 63 keyword.usage_count = 32;
65 keyword.prepopulate_id = 10; 64 keyword.prepopulate_id = 10;
66 keyword.sync_guid = "1234-5678-90AB-CDEF"; 65 keyword.sync_guid = "1234-5678-90AB-CDEF";
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 EXPECT_EQ(1U, keywords.size()); 116 EXPECT_EQ(1U, keywords.size());
118 const TemplateURLData& restored_keyword = keywords.front(); 117 const TemplateURLData& restored_keyword = keywords.front();
119 118
120 EXPECT_EQ(keyword.short_name(), restored_keyword.short_name()); 119 EXPECT_EQ(keyword.short_name(), restored_keyword.short_name());
121 EXPECT_EQ(keyword.keyword(), restored_keyword.keyword()); 120 EXPECT_EQ(keyword.keyword(), restored_keyword.keyword());
122 EXPECT_EQ(keyword.url(), restored_keyword.url()); 121 EXPECT_EQ(keyword.url(), restored_keyword.url());
123 EXPECT_EQ(keyword.suggestions_url, restored_keyword.suggestions_url); 122 EXPECT_EQ(keyword.suggestions_url, restored_keyword.suggestions_url);
124 EXPECT_EQ(keyword.instant_url, restored_keyword.instant_url); 123 EXPECT_EQ(keyword.instant_url, restored_keyword.instant_url);
125 EXPECT_EQ(keyword.favicon_url, restored_keyword.favicon_url); 124 EXPECT_EQ(keyword.favicon_url, restored_keyword.favicon_url);
126 EXPECT_EQ(keyword.originating_url, restored_keyword.originating_url); 125 EXPECT_EQ(keyword.originating_url, restored_keyword.originating_url);
127 EXPECT_EQ(keyword.show_in_default_list,
128 restored_keyword.show_in_default_list);
129 EXPECT_EQ(keyword.safe_for_autoreplace, 126 EXPECT_EQ(keyword.safe_for_autoreplace,
130 restored_keyword.safe_for_autoreplace); 127 restored_keyword.safe_for_autoreplace);
131 EXPECT_EQ(keyword.input_encodings, restored_keyword.input_encodings); 128 EXPECT_EQ(keyword.input_encodings, restored_keyword.input_encodings);
132 EXPECT_EQ(keyword.id, restored_keyword.id); 129 EXPECT_EQ(keyword.id, restored_keyword.id);
133 // The database stores time only at the resolution of a second. 130 // The database stores time only at the resolution of a second.
134 EXPECT_EQ(keyword.date_created.ToTimeT(), 131 EXPECT_EQ(keyword.date_created.ToTimeT(),
135 restored_keyword.date_created.ToTimeT()); 132 restored_keyword.date_created.ToTimeT());
136 EXPECT_EQ(keyword.last_modified.ToTimeT(), 133 EXPECT_EQ(keyword.last_modified.ToTimeT(),
137 restored_keyword.last_modified.ToTimeT()); 134 restored_keyword.last_modified.ToTimeT());
138 EXPECT_EQ(keyword.created_by_policy, restored_keyword.created_by_policy); 135 EXPECT_EQ(keyword.created_by_policy, restored_keyword.created_by_policy);
(...skipping 22 matching lines...) Expand all
161 KeywordTable::Keywords keywords(GetKeywords()); 158 KeywordTable::Keywords keywords(GetKeywords());
162 EXPECT_EQ(1U, keywords.size()); 159 EXPECT_EQ(1U, keywords.size());
163 const TemplateURLData& restored_keyword = keywords.front(); 160 const TemplateURLData& restored_keyword = keywords.front();
164 161
165 EXPECT_EQ(keyword.short_name(), restored_keyword.short_name()); 162 EXPECT_EQ(keyword.short_name(), restored_keyword.short_name());
166 EXPECT_EQ(keyword.keyword(), restored_keyword.keyword()); 163 EXPECT_EQ(keyword.keyword(), restored_keyword.keyword());
167 EXPECT_EQ(keyword.suggestions_url, restored_keyword.suggestions_url); 164 EXPECT_EQ(keyword.suggestions_url, restored_keyword.suggestions_url);
168 EXPECT_EQ(keyword.instant_url, restored_keyword.instant_url); 165 EXPECT_EQ(keyword.instant_url, restored_keyword.instant_url);
169 EXPECT_EQ(keyword.favicon_url, restored_keyword.favicon_url); 166 EXPECT_EQ(keyword.favicon_url, restored_keyword.favicon_url);
170 EXPECT_EQ(keyword.originating_url, restored_keyword.originating_url); 167 EXPECT_EQ(keyword.originating_url, restored_keyword.originating_url);
171 EXPECT_EQ(keyword.show_in_default_list,
172 restored_keyword.show_in_default_list);
173 EXPECT_EQ(keyword.safe_for_autoreplace, 168 EXPECT_EQ(keyword.safe_for_autoreplace,
174 restored_keyword.safe_for_autoreplace); 169 restored_keyword.safe_for_autoreplace);
175 EXPECT_EQ(keyword.input_encodings, restored_keyword.input_encodings); 170 EXPECT_EQ(keyword.input_encodings, restored_keyword.input_encodings);
176 EXPECT_EQ(keyword.id, restored_keyword.id); 171 EXPECT_EQ(keyword.id, restored_keyword.id);
177 EXPECT_EQ(keyword.prepopulate_id, restored_keyword.prepopulate_id); 172 EXPECT_EQ(keyword.prepopulate_id, restored_keyword.prepopulate_id);
178 } 173 }
179 174
180 TEST_F(KeywordTableTest, KeywordWithNoFavicon) { 175 TEST_F(KeywordTableTest, KeywordWithNoFavicon) {
181 TemplateURLData keyword; 176 TemplateURLData keyword;
182 keyword.SetShortName(ASCIIToUTF16("short_name")); 177 keyword.SetShortName(ASCIIToUTF16("short_name"));
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 keyword.id = 2000; 242 keyword.id = 2000;
248 AddKeyword(keyword); 243 AddKeyword(keyword);
249 KeywordTable::Keywords keywords(GetKeywords()); 244 KeywordTable::Keywords keywords(GetKeywords());
250 EXPECT_EQ(1U, keywords.size()); 245 EXPECT_EQ(1U, keywords.size());
251 const TemplateURLData& keyword_from_database = keywords.front(); 246 const TemplateURLData& keyword_from_database = keywords.front();
252 EXPECT_EQ(keyword.id, keyword_from_database.id); 247 EXPECT_EQ(keyword.id, keyword_from_database.id);
253 EXPECT_EQ(ASCIIToUTF16("bogus name"), keyword_from_database.short_name()); 248 EXPECT_EQ(ASCIIToUTF16("bogus name"), keyword_from_database.short_name());
254 RemoveKeyword(keyword.id); 249 RemoveKeyword(keyword.id);
255 } 250 }
256 } 251 }
OLDNEW
« no previous file with comments | « components/search_engines/keyword_table.cc ('k') | components/search_engines/template_url.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698