MacViews: Better layering for the touch selection controller

MacViews: Better layering for the touch selection controller

This CL moves ViewsTouchSelectionControllerFactory out of
views/touchui/touch_selection_controller_impl.cc and into its own file
one level higher.

Result: the single touchui dependency moves from views_delegate.cc to a
file that can be controlled on a per-platform basis. The touchui
subfolder assumes aura is available. This allows touchui to be excluded
from a build that doesn't need it.

BUG=366007
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265814

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265882

[tapted, 2014-04-23 09:09:19]

Hi Ben, please take a look (just 2 today.. don't want to flood you).

[Ben Goodger (Google), 2014-04-23 15:58:34]

lgtm

[tapted, 2014-04-23 23:40:11]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2014-04-23 23:40:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tapted@chromium.org/248763003/1

[commit-bot: I haz the power, 2014-04-24 01:48:22]

Change committed as 265814

[Vadim Sh., 2014-04-24 01:58:05]

A revert of this CL has been created in
https://codereview.chromium.org/258483002/ by vadimsh@chromium.org.

The reason for reverting is: Failed to compile on ChromiumOS Linux:

./../ui/views/touchui/touch_selection_controller_impl_unittest.cc:20:57: fatal
error: ui/views/touch_selection_controller_factory.h: No such file or directory
compilation terminated.

See
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2....

[tfarina, 2014-04-24 02:12:39]

On 2014/04/24 01:58:05, Vadim Sh. wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/258483002/ by mailto:vadimsh@chromium.org.
> 
> The reason for reverting is: Failed to compile on ChromiumOS Linux:
> 
> ./../ui/views/touchui/touch_selection_controller_impl_unittest.cc:20:57: fatal
> error: ui/views/touch_selection_controller_factory.h: No such file or
directory
> compilation terminated.
> 
> See
>
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2....

Can we track down this difference between what CQ is running and what Waterfall
is running? If the later is running something TS and CQ aren't then reverts like
that will happen ever. We should eliminate this difference to make the life of
devs better.

[tfarina, 2014-04-24 02:14:34]

https://codereview.chromium.org/248763003/diff/1/ui/views/touchui/touch_selec...
File ui/views/touchui/touch_selection_controller_impl_unittest.cc (right):

https://codereview.chromium.org/248763003/diff/1/ui/views/touchui/touch_selec...
ui/views/touchui/touch_selection_controller_impl_unittest.cc:20: #include
"ui/views/touch_selection_controller_factory.h"
the file seems to be called, views_touch_selection_controller_factory.h

[tfarina, 2014-04-24 02:21:49]

The problem is that tryserver.chromium:linux_chromium_chromeos_rel is not
building views_unittests. But the build chromium.chromiumos in the Waterfall is.

[tfarina, 2014-04-24 02:24:30]

I have a CL that adds some missing targets to tryserver.chromium in
https://codereview.chromium.org/246513003/. I will prepare another to add
views_unittests as well.

[tapted, 2014-04-24 03:13:59]

thanks for tracking that down Thiago! I thought it might be something like
that... We had the same thing on app_list_unittests for a while. Makes landing
patches very scary.

Annoying that the CQ didn't catch my silly derp - the new recipe format will be
pretty awesome once it's configured though.

linux_chromeos_asan actually came close as well, but there were some flaky
compiles that may have confused the CQ ("undefined reference to main linking
layout_test_helper") - doh.

Double-checking everything on a local CrOS build now..

https://codereview.chromium.org/248763003/diff/1/ui/views/touchui/touch_selec...
File ui/views/touchui/touch_selection_controller_impl_unittest.cc (right):

https://codereview.chromium.org/248763003/diff/1/ui/views/touchui/touch_selec...
ui/views/touchui/touch_selection_controller_impl_unittest.cc:20: #include
"ui/views/touch_selection_controller_factory.h"
On 2014/04/24 02:14:35, tfarina wrote:
> the file seems to be called, views_touch_selection_controller_factory.h

Done. (drat)

[tapted, 2014-04-24 06:31:17]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2014-04-24 06:31:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tapted@chromium.org/248763003/80001

[commit-bot: I haz the power, 2014-04-24 08:32:08]

Change committed as 265882