Notify Files App when ARC++ app is installed/removed

components/arc/intent_helper/arc_intent_helper_bridge.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_ARC_INTENT_HELPER_ARC_INTENT_HELPER_BRIDGE_H_
 #define COMPONENTS_ARC_INTENT_HELPER_ARC_INTENT_HELPER_BRIDGE_H_
 
 #include <memory>
 #include <string>
 
 #include "ash/link_handler_model_factory.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
+#include "base/observer_list.h"
 #include "base/threading/thread_checker.h"
 #include "components/arc/arc_service.h"
 #include "components/arc/common/intent_helper.mojom.h"
 #include "components/arc/instance_holder.h"
 #include "mojo/public/cpp/bindings/binding.h"
 
 namespace ash {
 
 class LinkHandlerModel;
 
@@ skipping 15 matching lines @@
  public:
   enum class GetResult {
     // Failed. The intent_helper instance is not yet ready. This is a temporary
     // error.
     FAILED_ARC_NOT_READY,
     // Failed. Either ARC is not supported at all or intent_helper instance
     // version is too old.
     FAILED_ARC_NOT_SUPPORTED,
   };
 
+  class Observer {
+   public:
+    virtual void OnAppsUpdated() = 0;

[hidehiko, 2016/11/17 07:34:19]

Document please.

[oka, 2016/11/21 07:02:15]

Done.

+  };

[Yusuke Sato, 2016/11/17 02:29:54]

Don't we need

 protected:
  virtual ~Observer() {}

?

[oka, 2016/11/21 07:02:15]

Done.

+
   ArcIntentHelperBridge(
       ArcBridgeService* bridge_service,
       const scoped_refptr<ActivityIconLoader>& icon_loader,
       const scoped_refptr<LocalActivityResolver>& activity_resolver);
   ~ArcIntentHelperBridge() override;
 
+  static ArcIntentHelperBridge* Get();

[hidehiko, 2016/11/17 07:34:19]

It's better to note this is something workaround, and encouraged to avoid as
much as possible.
Also, could you document when this returns an instance, and when not?

[oka, 2016/11/21 07:02:15]

Done.

+
+  void AddObserver(Observer* observer);
+
   // InstanceHolder<mojom::IntentHelperInstance>::Observer
   void OnInstanceReady() override;
   void OnInstanceClosed() override;
 
   // mojom::IntentHelperHost
   void OnIconInvalidated(const mojo::String& package_name) override;
   void OnIntentFiltersUpdated(
       mojo::Array<mojom::IntentFilterPtr> intent_filters) override;
   void OnOpenDownloads() override;
   void OnOpenUrl(const mojo::String& url) override;
@@ skipping 25 matching lines @@
 
   static const char kArcIntentHelperPackageName[];
 
  private:
   mojo::Binding<mojom::IntentHelperHost> binding_;
   scoped_refptr<ActivityIconLoader> icon_loader_;
   scoped_refptr<LocalActivityResolver> activity_resolver_;
 
   base::ThreadChecker thread_checker_;
 
+  base::ObserverList<Observer> observer_list_;
+
   DISALLOW_COPY_AND_ASSIGN(ArcIntentHelperBridge);
 };
 
 }  // namespace arc
 
 #endif  // COMPONENTS_ARC_INTENT_HELPER_ARC_INTENT_HELPER_BRIDGE_H_