Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2487573005:
[Interpreter] Optimize for monomorphic case in Call and New bytecode handlers. (Closed)
Description[Interpreter] Optimize for monomorphic case in Call and New bytecode handlers.
Fast case the monomorphic case, by marking the additional checks as deferred
blocks. This increases the code size by about 50 bytes, but the monmorphic
case requires one fewer jump and the all the code is contiguous, so may help
caching.
Also cleanup call and new bytecode handlers by changing some of the Branches
to GotoIf/Unless for better readability.
BUG=v8:4280
Committed: https://crrev.com/be360af21a9ab958d7705020ed63a0275c386b0b
Cr-Commit-Position: refs/heads/master@{#40910}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fixed comments. #Messages
Total messages: 20 (14 generated)
The CQ bit was checked by mythria@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [Interpreter] Optimize for monomorphic case in Call and New bytecode handlers. Fast case the monomorphic case, by marking the additional checks as deferred blocks. This increases the code size by about 50 bytes, but the monmorphic case requires one fewer jump and the all the code is contiguous, so may help caching. Also cleanup call and new bytecode handlers by changing some of the Branches to GotoIf/Unless for better readability. BUG=v8:4280, v8:5210 ========== to ========== [Interpreter] Optimize for monomorphic case in Call and New bytecode handlers. Fast case the monomorphic case, by marking the additional checks as deferred blocks. This increases the code size by about 50 bytes, but the monmorphic case requires one fewer jump and the all the code is contiguous, so may help caching. Also cleanup call and new bytecode handlers by changing some of the Branches to GotoIf/Unless for better readability. BUG=v8:4280 ==========
mythria@chromium.org changed reviewers: + rmcilroy@chromium.org
This cl is to cleanup call and new bytecode handlers. The only important change is to move CallFunction to be immediately after the monomorphic check. I was hoping it will improve the call/new by a bit but it does not seem to. I also changed some of the branches to GotoIf/GotoUnless for better readability. PTAL. Thanks, Mythri
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM, thanks. https://codereview.chromium.org/2487573005/diff/1/src/interpreter/interpreter... File src/interpreter/interpreter-assembler.cc (right): https://codereview.chromium.org/2487573005/diff/1/src/interpreter/interpreter... src/interpreter/interpreter-assembler.cc:786: // Make sure the function is the Array() function nit - fullstops at end of comments
Thanks Ross. fixed the comments. https://codereview.chromium.org/2487573005/diff/1/src/interpreter/interpreter... File src/interpreter/interpreter-assembler.cc (right): https://codereview.chromium.org/2487573005/diff/1/src/interpreter/interpreter... src/interpreter/interpreter-assembler.cc:786: // Make sure the function is the Array() function On 2016/11/09 15:16:07, rmcilroy wrote: > nit - fullstops at end of comments Done.
The CQ bit was checked by mythria@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mythria@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rmcilroy@chromium.org Link to the patchset: https://codereview.chromium.org/2487573005/#ps20001 (title: "Fixed comments.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Optimize for monomorphic case in Call and New bytecode handlers. Fast case the monomorphic case, by marking the additional checks as deferred blocks. This increases the code size by about 50 bytes, but the monmorphic case requires one fewer jump and the all the code is contiguous, so may help caching. Also cleanup call and new bytecode handlers by changing some of the Branches to GotoIf/Unless for better readability. BUG=v8:4280 ========== to ========== [Interpreter] Optimize for monomorphic case in Call and New bytecode handlers. Fast case the monomorphic case, by marking the additional checks as deferred blocks. This increases the code size by about 50 bytes, but the monmorphic case requires one fewer jump and the all the code is contiguous, so may help caching. Also cleanup call and new bytecode handlers by changing some of the Branches to GotoIf/Unless for better readability. BUG=v8:4280 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Optimize for monomorphic case in Call and New bytecode handlers. Fast case the monomorphic case, by marking the additional checks as deferred blocks. This increases the code size by about 50 bytes, but the monmorphic case requires one fewer jump and the all the code is contiguous, so may help caching. Also cleanup call and new bytecode handlers by changing some of the Branches to GotoIf/Unless for better readability. BUG=v8:4280 ========== to ========== [Interpreter] Optimize for monomorphic case in Call and New bytecode handlers. Fast case the monomorphic case, by marking the additional checks as deferred blocks. This increases the code size by about 50 bytes, but the monmorphic case requires one fewer jump and the all the code is contiguous, so may help caching. Also cleanup call and new bytecode handlers by changing some of the Branches to GotoIf/Unless for better readability. BUG=v8:4280 Committed: https://crrev.com/be360af21a9ab958d7705020ed63a0275c386b0b Cr-Commit-Position: refs/heads/master@{#40910} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/be360af21a9ab958d7705020ed63a0275c386b0b Cr-Commit-Position: refs/heads/master@{#40910} |
