Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: chrome/browser/ui/startup/startup_tab_provider.h

Issue 2487553002: Moving new First Run to use per-profile value, rather than simply checking IsChromeFirstRun. (Closed)
Patch Set: Addressing pkasting feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/startup/startup_tab_provider.h
diff --git a/chrome/browser/ui/startup/startup_tab_provider.h b/chrome/browser/ui/startup/startup_tab_provider.h
index 0c24d83a52b418501e2f13281ce9eca7e8ec82a5..1a75d09250cef9796609c4b66354e4904cc972f8 100644
--- a/chrome/browser/ui/startup/startup_tab_provider.h
+++ b/chrome/browser/ui/startup/startup_tab_provider.h
@@ -22,7 +22,7 @@ class StartupTabProvider {
public:
// Gathers relevant system state and returns any tabs which should be
// shown according to onboarding/first run policy.
- virtual StartupTabs GetOnboardingTabs() const = 0;
+ virtual StartupTabs GetOnboardingTabs(Profile* profile) const = 0;
// Gathers URLs from a Master Preferences file indicating first run logic
// specific to this distribution. Transforms any such URLs per policy and
@@ -60,7 +60,10 @@ class StartupTabProviderImpl : public StartupTabProvider {
// Determines which tabs which should be shown according to onboarding/first
// run policy.
- static StartupTabs CheckStandardOnboardingTabPolicy(bool is_first_run);
+ static StartupTabs CheckStandardOnboardingTabPolicy(
+ bool is_first_run,
+ bool has_seen_welcome_page,
+ bool is_signed_in);
// Processes first run URLs specified in Master Preferences file, replacing
// any "magic word" URL hosts with appropriate URLs.
@@ -87,15 +90,18 @@ class StartupTabProviderImpl : public StartupTabProvider {
// explicitly specified. Session Restore does not expect the NTP to be passed.
static StartupTabs CheckNewTabPageTabPolicy(const SessionStartupPref& pref);
- // Gets the URL for the "Welcome to Chrome" page.
- static GURL GetWelcomePageUrl();
+ // Gets the URL for the Welcome page. If |use_later_run_variant| is true, a
+ // URL parameter will be appended so as to access the variant page used when
+ // onboarding occurs after the first Chrome execution (e.g., when creating an
+ // additional profile).
+ static GURL GetWelcomePageUrl(bool use_later_run_variant);
// Gets the URL for the page which offers to reset the user's profile
// settings.
static GURL GetTriggeredResetSettingsUrl();
// StartupTabProvider:
- StartupTabs GetOnboardingTabs() const override;
+ StartupTabs GetOnboardingTabs(Profile* profile) const override;
StartupTabs GetDistributionFirstRunTabs(
StartupBrowserCreator* browser_creator) const override;
StartupTabs GetResetTriggerTabs(Profile* profile) const override;
« no previous file with comments | « chrome/browser/ui/startup/startup_browser_creator_impl_unittest.cc ('k') | chrome/browser/ui/startup/startup_tab_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698