Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 2487523002: Remove redundant disabling of DesktopMediaListAshTest. (Closed)

Created:
4 years, 1 month ago by benwells
Modified:
4 years, 1 month ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant disabling of DesktopMediaListAshTest. The test was disabled on Windows, but Ash isn't a thing on Windows any more so the ifdeffery to disable it can be removed. It also only timed out on DrMemory (according to the comment) which also isn't a thing. BUG=493187, 655521 Committed: https://crrev.com/e144de966f4224bbcef74582dfd49ac324d15dec Cr-Commit-Position: refs/heads/master@{#430712}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M chrome/browser/media/webrtc/desktop_media_list_ash_unittest.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
benwells
4 years, 1 month ago (2016-11-08 00:14:15 UTC) #6
tommi (sloooow) - chröme
lgtm
4 years, 1 month ago (2016-11-08 18:14:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487523002/1
4 years, 1 month ago (2016-11-08 20:58:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 21:05:19 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 21:06:50 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e144de966f4224bbcef74582dfd49ac324d15dec
Cr-Commit-Position: refs/heads/master@{#430712}

Powered by Google App Engine
This is Rietveld 408576698