Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2487513002: Include posInSet and setSize in tab output rule (Closed)

Created:
4 years, 1 month ago by David Tseng
Modified:
4 years, 1 month ago
Reviewers:
dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include posInSet and setSize in tab output rule BUG=619283 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/bf7c1917df4dcb7d60df5147cae1c3ab9e539fae Cr-Commit-Position: refs/heads/master@{#430515}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
David Tseng
4 years, 1 month ago (2016-11-07 22:30:42 UTC) #4
dmazzoni
lgtm
4 years, 1 month ago (2016-11-07 23:53:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487513002/1
4 years, 1 month ago (2016-11-08 03:02:13 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 04:04:59 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 04:11:41 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf7c1917df4dcb7d60df5147cae1c3ab9e539fae
Cr-Commit-Position: refs/heads/master@{#430515}

Powered by Google App Engine
This is Rietveld 408576698