Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: test/cctest/interpreter/bytecode_expectations/LookupSlot.golden

Issue 2487483004: Only treat possible eval calls going through 'with' as special. (Closed)
Patch Set: Fix AstGraphBuilder Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/interpreter/bytecode_expectations/LookupSlot.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/LookupSlot.golden b/test/cctest/interpreter/bytecode_expectations/LookupSlot.golden
index 8e36d68d63ddeb6c1fe12f007c41ab295acc82d0..cc2c901440965c18a9a3957244fd045755ba15a2 100644
--- a/test/cctest/interpreter/bytecode_expectations/LookupSlot.golden
+++ b/test/cctest/interpreter/bytecode_expectations/LookupSlot.golden
@@ -12,7 +12,7 @@ snippet: "
"
frame size: 10
parameter count: 1
-bytecode array length: 67
+bytecode array length: 65
bytecodes: [
B(CreateFunctionContext), U8(3),
B(PushContext), R(0),
@@ -23,9 +23,9 @@ bytecodes: [
B(Ldar), R(new_target),
B(StaCurrentContextSlot), U8(5),
/* 10 E> */ B(StackCheck),
- /* 14 S> */ B(LdaConstant), U8(0),
- B(Star), R(4),
- B(CallRuntimeForPair), U16(Runtime::kLoadLookupSlotForCall), R(4), U8(1), R(1),
+ /* 14 S> */ B(LdrUndefined), R(2),
+ /* 14 E> */ B(LdaLookupGlobalSlot), U8(0), U8(4), U8(1),
+ B(Star), R(1),
B(LdaConstant), U8(1),
B(Star), R(3),
B(LdaZero),
@@ -57,7 +57,7 @@ snippet: "
"
frame size: 10
parameter count: 1
-bytecode array length: 68
+bytecode array length: 66
bytecodes: [
B(CreateFunctionContext), U8(3),
B(PushContext), R(0),
@@ -68,9 +68,9 @@ bytecodes: [
B(Ldar), R(new_target),
B(StaCurrentContextSlot), U8(5),
/* 10 E> */ B(StackCheck),
- /* 14 S> */ B(LdaConstant), U8(0),
- B(Star), R(4),
- B(CallRuntimeForPair), U16(Runtime::kLoadLookupSlotForCall), R(4), U8(1), R(1),
+ /* 14 S> */ B(LdrUndefined), R(2),
+ /* 14 E> */ B(LdaLookupGlobalSlot), U8(0), U8(4), U8(1),
+ B(Star), R(1),
B(LdaConstant), U8(1),
B(Star), R(3),
B(LdaZero),
@@ -103,7 +103,7 @@ snippet: "
"
frame size: 10
parameter count: 1
-bytecode array length: 67
+bytecode array length: 65
bytecodes: [
B(CreateFunctionContext), U8(3),
B(PushContext), R(0),
@@ -116,9 +116,9 @@ bytecodes: [
/* 10 E> */ B(StackCheck),
/* 14 S> */ B(LdaSmi), U8(20),
/* 16 E> */ B(StaLookupSlotSloppy), U8(0),
- /* 22 S> */ B(LdaConstant), U8(1),
- B(Star), R(4),
- B(CallRuntimeForPair), U16(Runtime::kLoadLookupSlotForCall), R(4), U8(1), R(1),
+ /* 22 S> */ B(LdrUndefined), R(2),
+ /* 29 E> */ B(LdaLookupGlobalSlot), U8(1), U8(4), U8(1),
+ B(Star), R(1),
B(LdaConstant), U8(2),
B(Star), R(3),
B(LdaZero),
@@ -154,7 +154,7 @@ snippet: "
"
frame size: 10
parameter count: 1
-bytecode array length: 67
+bytecode array length: 65
bytecodes: [
B(CreateFunctionContext), U8(3),
B(PushContext), R(0),
@@ -165,9 +165,9 @@ bytecodes: [
B(Ldar), R(new_target),
B(StaCurrentContextSlot), U8(5),
/* 38 E> */ B(StackCheck),
- /* 44 S> */ B(LdaConstant), U8(0),
- B(Star), R(4),
- B(CallRuntimeForPair), U16(Runtime::kLoadLookupSlotForCall), R(4), U8(1), R(1),
+ /* 44 S> */ B(LdrUndefined), R(2),
+ /* 44 E> */ B(LdaLookupGlobalSlot), U8(0), U8(4), U8(1),
+ B(Star), R(1),
B(LdaConstant), U8(1),
B(Star), R(3),
B(LdaZero),
@@ -204,7 +204,7 @@ snippet: "
"
frame size: 10
parameter count: 1
-bytecode array length: 67
+bytecode array length: 65
bytecodes: [
B(CreateFunctionContext), U8(3),
B(PushContext), R(0),
@@ -215,9 +215,9 @@ bytecodes: [
B(Ldar), R(new_target),
B(StaCurrentContextSlot), U8(5),
/* 34 E> */ B(StackCheck),
- /* 40 S> */ B(LdaConstant), U8(0),
- B(Star), R(4),
- B(CallRuntimeForPair), U16(Runtime::kLoadLookupSlotForCall), R(4), U8(1), R(1),
+ /* 40 S> */ B(LdrUndefined), R(2),
+ /* 40 E> */ B(LdaLookupGlobalSlot), U8(0), U8(4), U8(1),
+ B(Star), R(1),
B(LdaConstant), U8(1),
B(Star), R(3),
B(LdaZero),
« src/full-codegen/full-codegen.cc ('K') | « test/cctest/interpreter/bytecode_expectations/Eval.golden ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698