test/cctest/interpreter/bytecode_expectations/CallLookupSlot.golden - Issue 2487483004: Only treat possible eval calls going through 'with' as special.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/interpreter/bytecode_expectations/CallLookupSlot.golden

Issue 2487483004: Only treat possible eval calls going through 'with' as special. (Closed)

Patch Set: Fix ast-graph-builder Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/compiler/ast-graph-builder.cc ('K') | « src/interpreter/bytecode-generator.cc ('k') | test/cctest/interpreter/bytecode_expectations/ContextVariables.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/cctest/interpreter/bytecode_expectations/CallLookupSlot.golden

diff --git a/test/cctest/interpreter/bytecode_expectations/CallLookupSlot.golden b/test/cctest/interpreter/bytecode_expectations/CallLookupSlot.golden

index 6e97ea7703f3edccaf3056d792a91e211d9082dc..e05419fbff145e9129c480bfdeaea5d73e1e0fd2 100644

--- a/test/cctest/interpreter/bytecode_expectations/CallLookupSlot.golden

+++ b/test/cctest/interpreter/bytecode_expectations/CallLookupSlot.golden

@@ -24,9 +24,10 @@ bytecodes: [

/* 30 E> */ B(StackCheck),

/* 34 S> */ B(CreateClosure), U8(0), U8(2),

/* 36 E> */ B(StaLookupSlotSloppy), U8(1),

- /* 52 S> */ B(LdaConstant), U8(2),

- B(Star), R(4),

- B(CallRuntimeForPair), U16(Runtime::kLoadLookupSlotForCall), R(4), U8(1), R(1),

+ /* 52 S> */ B(LdaUndefined),

+ B(Star), R(2),

+ /* 52 E> */ B(LdaLookupGlobalSlot), U8(2), U8(4), U8(1),

+ B(Star), R(1),

B(LdaConstant), U8(3),

B(Star), R(3),

B(LdaZero),

@@ -41,7 +42,8 @@ bytecodes: [

B(CallRuntime), U16(Runtime::kResolvePossiblyDirectEval), R(4), U8(6),

B(Star), R(1),

/* 52 E> */ B(Call), R(1), R(2), U8(2), U8(2),

- /* 62 S> */ B(LdrUndefined), R(2),

+ /* 62 S> */ B(LdaUndefined),

+ B(Star), R(2),

/* 69 E> */ B(LdaLookupGlobalSlot), U8(1), U8(8), U8(1),

B(Star), R(1),

/* 69 E> */ B(Call), R(1), R(2), U8(1), U8(6),