Only treat possible eval calls going through 'with' as special.

src/full-codegen/full-codegen.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/full-codegen/full-codegen.h"
 
 #include "src/ast/ast-numbering.h"
 #include "src/ast/ast.h"
 #include "src/ast/prettyprinter.h"
 #include "src/ast/scopes.h"
@@ skipping 1651 matching lines @@
 #endif
 
   Comment cmnt(masm_, (expr->tail_call_mode() == TailCallMode::kAllow)
                           ? "[ TailCall"
                           : "[ Call");
   Expression* callee = expr->expression();
   Call::CallType call_type = expr->GetCallType();
 
   switch (call_type) {
     case Call::POSSIBLY_EVAL_CALL:
+    case Call::POSSIBLY_EVAL_THROUGH_WITH_CALL:

[Toon Verwaest, 2016/11/09 14:13:08]

Shouldn't POSSIBLY_EVAL_CALL be moved to OTHER_CALL now? Here and the
ast-graph-builder?

[rmcilroy, 2016/11/09 17:02:29]

Nope because we also need to resolve the eval function for POSSIBLY_EVAL_CALL
which we don't do with OTHER_CALL (there is no possibly_eval branch below like
there is in ast-graph-builder / bytecode-graph-builder).

Given that we never actually go through FCG for functions with eval any longer
(since they will be optimized by Turbofan, so always go through Ignition after
the change which feeds all TF code via Ignition) I don't think it's worth doing
any work here - we will eventually rip support for eval out of FCG once we are
sure the TF via Ignition change is going to stick.

[Toon Verwaest, 2016/11/10 09:40:19]

I see. But it is still relevant in the ast-graph-builder though right?

       EmitPossiblyEvalCall(expr);
       break;
     case Call::GLOBAL_CALL:
       EmitCallWithLoadIC(expr);
       break;
     case Call::WITH_CALL:
       // Call to a lookup slot looked up through a with scope.
       PushCalleeAndWithBaseObject(expr);
       EmitCall(expr);
       break;
@@ skipping 309 matching lines @@
   return info_->has_simple_parameters();
 }
 
 FunctionLiteral* FullCodeGenerator::literal() const { return info_->literal(); }
 
 #undef __
 
 
 }  // namespace internal
 }  // namespace v8