Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9125)

Unified Diff: chrome/test/data/webui/settings/appearance_page_test.js

Issue 2487423002: MD Settings: add tests for mischievous default zoom handling (Closed)
Patch Set: closure Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/appearance_page/compiled_resources2.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/appearance_page_test.js
diff --git a/chrome/test/data/webui/settings/appearance_page_test.js b/chrome/test/data/webui/settings/appearance_page_test.js
index 2e08fb5db526986c3ceac32d2a30c7989a6d18b4..92c08a5dfc3acaa866e6c62289a422feab8a70f4 100644
--- a/chrome/test/data/webui/settings/appearance_page_test.js
+++ b/chrome/test/data/webui/settings/appearance_page_test.js
@@ -9,19 +9,29 @@
*/
var TestAppearanceBrowserProxy = function() {
settings.TestBrowserProxy.call(this, [
+ 'getDefaultZoom',
'getThemeInfo',
'isSupervised',
'openWallpaperManager',
'useDefaultTheme',
'useSystemTheme',
]);
+
+ /** @private */
+ this.defaultZoom_ = 1;
+
+ /** @private */
+ this.isSupervised_ = false;
};
TestAppearanceBrowserProxy.prototype = {
__proto__: settings.TestBrowserProxy.prototype,
- /** @private */
- isSupervised_: false,
+ /** @override */
+ getDefaultZoom: function() {
+ this.methodCalled('getDefaultZoom');
+ return Promise.resolve(this.defaultZoom_);
+ },
/** @override */
getThemeInfo: function(themeId) {
@@ -50,6 +60,11 @@ TestAppearanceBrowserProxy.prototype = {
this.methodCalled('useSystemTheme');
},
+ /** @param {number} defaultZoom */
+ setDefaultZoom: function(defaultZoom) {
+ this.defaultZoom_ = defaultZoom;
+ },
+
/** @param {boolean} Whether the user is supervised */
setIsSupervised: function(isSupervised) {
this.isSupervised_ = isSupervised;
@@ -61,28 +76,33 @@ var appearancePage = null;
/** @type {?TestAppearanceBrowserProxy} */
var appearanceBrowserProxy = null;
+function createAppearancePage() {
+ appearanceBrowserProxy.reset();
+ PolymerTest.clearBody();
+
+ appearancePage = document.createElement('settings-appearance-page');
+ appearancePage.set('prefs', {
+ extensions: {
+ theme: {
+ id: {
+ value: '',
+ },
+ use_system: {
+ value: false,
+ },
+ },
+ },
+ });
+
+ document.body.appendChild(appearancePage);
+ Polymer.dom.flush();
+}
+
suite('AppearanceHandler', function() {
setup(function() {
appearanceBrowserProxy = new TestAppearanceBrowserProxy();
settings.AppearanceBrowserProxyImpl.instance_ = appearanceBrowserProxy;
-
- PolymerTest.clearBody();
-
- appearancePage = document.createElement('settings-appearance-page');
- appearancePage.set('prefs', {
- extensions: {
- theme: {
- id: {
- value: '',
- },
- use_system: {
- value: false,
- },
- },
- },
- });
- document.body.appendChild(appearancePage);
- Polymer.dom.flush();
+ createAppearancePage();
});
teardown(function() { appearancePage.remove(); });
@@ -175,4 +195,33 @@ suite('AppearanceHandler', function() {
return appearanceBrowserProxy.whenCalled('useDefaultTheme');
});
}
+
+ test('default zoom handling', function() {
+ function getDefaultZoomText() {
+ var zoomLevel = appearancePage.$.zoomLevel;
+ return zoomLevel.options[zoomLevel.selectedIndex].textContent.trim();
+ }
+
+ return appearanceBrowserProxy.whenCalled('getDefaultZoom').then(function() {
+ assertEquals('100%', getDefaultZoomText());
+
+ appearanceBrowserProxy.setDefaultZoom(2 / 3);
+ createAppearancePage();
+ return appearanceBrowserProxy.whenCalled('getDefaultZoom');
+ }).then(function() {
+ assertEquals('67%', getDefaultZoomText());
+
+ appearanceBrowserProxy.setDefaultZoom(11 / 10);
+ createAppearancePage();
+ return appearanceBrowserProxy.whenCalled('getDefaultZoom');
+ }).then(function() {
+ assertEquals('110%', getDefaultZoomText());
+
+ appearanceBrowserProxy.setDefaultZoom(1.7499999999999);
+ createAppearancePage();
+ return appearanceBrowserProxy.whenCalled('getDefaultZoom');
+ }).then(function() {
+ assertEquals('175%', getDefaultZoomText());
+ });
+ });
});
« no previous file with comments | « chrome/browser/resources/settings/appearance_page/compiled_resources2.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698