chrome/browser/resources/settings/appearance_page/appearance_page.js - Issue 2487423002: MD Settings: add tests for mischievous default zoom handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_page.js

Issue 2487423002: MD Settings: add tests for mischievous default zoom handling (Closed)

Patch Set: closure Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/appearance_page/appearance_browser_proxy.js ('k') | chrome/browser/resources/settings/appearance_page/compiled_resources2.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/appearance_page/appearance_page.js

diff --git a/chrome/browser/resources/settings/appearance_page/appearance_page.js b/chrome/browser/resources/settings/appearance_page/appearance_page.js

index 690888a112d7da597a8c386ca1e03c0197f6f486..e5f2dc330339c9924a567107eca3f6116399a25b 100644

--- a/chrome/browser/resources/settings/appearance_page/appearance_page.js

+++ b/chrome/browser/resources/settings/appearance_page/appearance_page.js

@@ -31,9 +31,6 @@ Polymer({

notify: true,

- /** @private {!settings.AppearanceBrowserProxy} */

- browserProxy_: Object,

/** @private */

defaultZoom_: Number,

@@ -94,6 +91,9 @@ Polymer({

+ /** @private {?settings.AppearanceBrowserProxy} */

+ browserProxy_: null,

/** @private {string} */

themeUrl_: '',

@@ -114,7 +114,7 @@ Polymer({

this.$.defaultFontSize.menuOptions = this.fontSizeOptions_;

// TODO(dschuyler): Look into adding a listener for the

// default zoom percent.

- chrome.settingsPrivate.getDefaultZoom(function(zoom) {

+ this.browserProxy_.getDefaultZoom().then(function(zoom) {

this.defaultZoom_ = zoom;

}.bind(this));